-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document receiving and transmitting of uds messages #282
Merged
mdabrowski1990
merged 9 commits into
main
from
document-receiving-and-transmitting-of-uds-messages
Oct 3, 2024
Merged
Document receiving and transmitting of uds messages #282
mdabrowski1990
merged 9 commits into
main
from
document-receiving-and-transmitting-of-uds-messages
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix wrong behavior in code - adjust existing test cases - update docs with key information - update docstrigs
Finish with knowledge base
- restructure transport_interface to shorten paths - update `user guide` for CAN
add TODO markers
- restructure example part of documentation - adjust existing example files - add examples files (empty)
Add user guide for CAN Transport Interface
Provide examples for message/packet sending and receiving
mdabrowski1990
added
documentation
Improvements or additions to documentation
CAN
Related to CAN specific implementation
labels
Oct 3, 2024
mdabrowski1990
added this to the 4) Message support in CAN Transport Interface milestone
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2689 2680 -9
Branches 652 648 -4
=========================================
- Hits 2689 2680 -9
|
mdabrowski1990
commented
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mdabrowski1990
deleted the
document-receiving-and-transmitting-of-uds-messages
branch
October 3, 2024 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update of documentation with information how to send and receive UDS messages using python-can Transport Interface.
Examples have been updated too.
I had to fix small pieces of code as they were not in lane with ISO 15765-2:2016.
How Has This Been Tested?
Process
I know the process and did my best to follow it