-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update "Fix #253: Use AdcStart() before each ReadAnalog value" #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not part of v0.19.0. If someone checks out v0.19.0 (the tag), they won't get this change.
You need to move line 1581 AHEAD of 1381, and not change 1384. See comments.
@terrillmoore changes in the file Catena-Arduino-Platform/src/lib/stm32/stm32l0/CatenaStm32L0_ReadAnalog.cpp Lines 174 to 177 in 88a771a
Trying to create a new pull-request with branch issue253 says no changes to compare. Is that ok to create a new branch and submit a pull-request?
|
It would be best to understand how this happened. I suggest that you fork this repo, first apply your pull request there, then you can push changes upstream from your repo once you are sure they are correct. |
I think the merge didn't pick up your changes -- you committed changes to issue253 after I merged. Reopen #253, rename your local branch to "issue253a" or something, and submit a new pr. |
Note this from the history above: More research points to #254. I reverted that, because the documentation was not done. Proper process was not followed. Proper process is to push additional changes to the branch used for PR #254, not to create a new branch. I am going to REVERT this PR as well, and you must push ALL your changes onto either #254, or a different new PR. Please get review from @mcciyssaroha for this, thanks. |
Advanced the version number in
README.md
andCatenaBase.h