Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #253: Use AdcStart() before each ReadAnalog value #254

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Conversation

dhineshkumarmcci
Copy link
Contributor

Added AdcStart() call before each AdcGetValue() to read the Channel value. With long time run, this fixed the ?CatenaStm32L0::ReadAnalog(3): CatenaStm32L0_ReadAnalog() failed (5), as reported in issue #253

@terrillmoore
Copy link
Member

@chwon64, can you please check?

Copy link
Collaborator

@chwon64 chwon64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@terrillmoore
Copy link
Member

I reverted this. We are required to update version numbers and documentation. This is not a new requirement. Please bear this in mind and update. Since this is not a release, the last (x.y.z.last) field of the version number must be advanced (but do not change x.y.z); and you must update the release history in README.md. If you review that, you'll see that for pre-releases I say:

HEAD contains the following changes.

Please bear this in mind, and check all other pending pull requests.

@dhineshkumarmcci
Copy link
Contributor Author

@terrillmoore I have updated the version number and updated release history in README.md. Also I have submitted a new pull request #256 for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants