-
Notifications
You must be signed in to change notification settings - Fork 35
feat: drawing canvas with brush tool (Fixes #93) #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drawing canvas with brush tool (Fixes #93) #98
Conversation
Our Pull Request Approval ProcessThanks for contributing! ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
|
@zxnb01 instead of adding all the different sub classes inside a single file |
|
done ,u can review now |
|
@zxnb01 |
Screen.Recording.2025-09-24.164239.mp4here is the demo. |
048f6ec to
1a95237
Compare
|
@may-tas resolved the merge conflicts in cubit folder |
|
@zxnb01 |
|
@may-tas made the changes as requested. Screen.Recording.2025-09-25.160619.mp4final video to ensure there is no breakage in the code. |
|
LGTM, Merging. |
Fixes #93
🎨 Drawing Canvas Implementation
This PR implements a comprehensive drawing system for the text editing app as requested in #93.
Features Implemented:
Single brush feature with advanced drawing capabilities
Brush size slider with intuitive controls and real-time preview
Comprehensive color palette with color picker and preset options
Improved brush size UI - updated to a better, more user-friendly design
Functionality Ensured:
Drawing files save correctly - all drawing data persists properly when saving pages
Text compatibility maintained - texts remain fully draggable and editable on the drawing screen
Seamless integration - text and drawing features work together without conflicts
Enhanced page previews - saved pages display properly with both drawings and texts intact
UI Improvements:
Better brush size interface - refined the brush size controls for improved user experience
Unified canvas - smooth interaction between text editing and drawing modes
Technical Implementation: