-
Notifications
You must be signed in to change notification settings - Fork 35
feat: centralize color management with const-compatible ColorConstants class and comprehensive documentation #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s with ColorConstants class across 11 files
…s with ColorConstants class across 11 files
…s with ColorConstants class across 11 files
…s with ColorConstants class across 11 files
…s with ColorConstants class across 11 files
Our Pull Request Approval ProcessThanks for contributing! ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Congratulations on making your first PR! If you haven't already, check out our Contributing Guidelines and README to ensure that you are following our guidelines for contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason for this removal? if not then please add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pubspec.yaml
Outdated
| color: "#ffffff" | ||
| image: assets/icons/whitebg.png | ||
|
|
||
| # Color centralization improvements implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
|
@Charmiseera Kindly upload a screen recording as proof of work. |
Sure |
|
@Charmiseera updates? |
|
I will update code as you suggested and upload working proof by today night. |
|
Alright. |
Hey @may-tas , I have updated the code and also uploaded the screen recording as working proof. |
|
@Charmiseera |
feat: centralize color management - replace scattered hardcoded colors with ColorConstants class across 11 files
What kind of change does this PR introduce?
Feature/Refactoring - This PR introduces a centralized color management system to improve code maintainability and consistency.
Issue Number:
Fixes #85
Snapshots/ video:
screen-capture.mp4
Summary
This PR addresses the issue of scattered hardcoded color values throughout the codebase by implementing a comprehensive centralized color management system.
Problems Solved:
Key Changes:
Files Modified:
Does this PR introduce a breaking change?
No - This PR does not introduce any breaking changes. All existing functionality is preserved while improving the underlying code organization. The changes are purely internal refactoring with no API or behavior modifications.
Other information
Benefits:
Technical Details:
Have you read the contributing guide , README.md , code of conduct?
Yes - All contribution guidelines, project documentation, and code of conduct have been reviewed and followed.