Skip to content

Fix test header formatting #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fix test header formatting #373

merged 1 commit into from
Jun 4, 2020

Conversation

maxitg
Copy link
Owner

@maxitg maxitg commented Jun 4, 2020

Changes

Comments

  • Apparently, the difference is due to version 1.5.0 that was released 4 days ago. Updating the CI now.

Examples

  • Before:
➜  SetReplace git:(master) ./lint.sh
libSetReplace/test/Set_test.cpp:5:  Found C++ system header after other system header.
  Should be: Set_test.h, c system, c++ system, other.  [build/include_order] [4]
Done processing libSetReplace/test/Set_test.cpp
Total errors found: 1
  • After:
➜  SetReplace git:(fixTestHeaderOrder) ./lint.sh

This change is Reviewable

@maxitg maxitg added weed Something isn't working infrastructure Has to do with changes to the development process, e.g., build scripts, CI, testing utilities labels Jun 4, 2020
@maxitg maxitg requested review from phcerdan and aokellermann June 4, 2020 17:09
@maxitg maxitg marked this pull request as draft June 4, 2020 17:15
@maxitg maxitg marked this pull request as ready for review June 4, 2020 18:51
@maxitg maxitg merged commit 2db03e5 into master Jun 4, 2020
@maxitg maxitg deleted the fixTestHeaderOrder branch June 4, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Has to do with changes to the development process, e.g., build scripts, CI, testing utilities weed Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants