Skip to content

fix generating streams parameters (ftp, log_files was broken) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2020
Merged

fix generating streams parameters (ftp, log_files was broken) #208

merged 2 commits into from
Jun 4, 2020

Conversation

appetito
Copy link

@appetito appetito commented Jun 4, 2020

Fixed API:

  • ftp.upload
  • ftp.download
  • log_files.download_log_file

Fixed ftp plugin key

JonasVautherin
JonasVautherin approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should be merged before #207 I think, and then #207 will need to run autogen again.

@julianoes
Copy link
Collaborator

Oops, sorry.

@JonasVautherin
Copy link
Collaborator

@appetito: sorry for the conflict 😅 . Would you mind updating your branch and running the autogen again? It shouldn't create much conflict, but note that mavsdk/generated disappeared and now plugins are in their own module in mavsdk, e.g. mavsdk/ftp/

@appetito appetito requested a review from JonasVautherin June 4, 2020 14:57
@appetito
Copy link
Author

appetito commented Jun 4, 2020

@appetito: sorry for the conflict

no problem), i updated my branch

JonasVautherin
JonasVautherin approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JonasVautherin JonasVautherin merged commit 2ef1875 into mavlink:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@appetito @julianoes @JonasVautherin