Skip to content

Commit 2ef1875

Browse files
Merge pull request #208 from appetito/master
fix generating streams parameters (ftp, log_files was broken)
2 parents 7abf4df + 3a44abc commit 2ef1875

File tree

4 files changed

+23
-1
lines changed

4 files changed

+23
-1
lines changed

mavsdk/ftp/ftp.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,8 @@ async def download(self, remote_file_path, local_dir):
345345
"""
346346

347347
request = ftp_pb2.SubscribeDownloadRequest()
348+
request.remote_file_path = remote_file_path
349+
request.local_dir = local_dir
348350
download_stream = self._stub.SubscribeDownload(request)
349351

350352
try:
@@ -393,6 +395,8 @@ async def upload(self, local_file_path, remote_dir):
393395
"""
394396

395397
request = ftp_pb2.SubscribeUploadRequest()
398+
request.local_file_path = local_file_path
399+
request.remote_dir = remote_dir
396400
upload_stream = self._stub.SubscribeUpload(request)
397401

398402
try:

mavsdk/log_files/log_files.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,8 @@ async def download_log_file(self, id, path):
392392
"""
393393

394394
request = logFiles_pb2.SubscribeDownloadLogFileRequest()
395+
request.id = id
396+
request.path = path
395397
download_log_file_stream = self._stub.SubscribeDownloadLogFile(request)
396398

397399
try:

mavsdk/system.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def follow_me(self) -> follow_me.FollowMe:
130130
def ftp(self) -> ftp.Ftp:
131131
if "ftp" not in self._plugins:
132132
raise RuntimeError(self.error_uninitialized("Ftp"))
133-
return self._plugins["Ftp"]
133+
return self._plugins["ftp"]
134134

135135
@property
136136
def geofence(self) -> geofence.Geofence:

other/templates/py/stream.j2

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,22 @@ async def {{ name.lower_snake_case }}(self{% for param in params %}, {{ param.na
2525
"""
2626

2727
request = {{ plugin_name.lower_camel_case }}_pb2.Subscribe{{ name.upper_camel_case }}Request()
28+
{% for param in params %}
29+
{%- if param.type_info.is_primitive -%}
30+
request.{{ param.name.lower_snake_case }} = {{ param.name.lower_snake_case }}
31+
{%- else -%}
32+
{% if param.type_info.is_repeated %}
33+
rpc_elems_list = []
34+
for elem in {{ param.name.lower_snake_case }}:
35+
rpc_elem = {{ plugin_name.lower_snake_case }}_pb2.{{ param.type_info.inner_name }}()
36+
elem.translate_to_rpc(rpc_elem)
37+
rpc_elems_list.append(rpc_elem)
38+
request.{{ param.name.lower_snake_case }}.extend(rpc_elems_list)
39+
{% else %}
40+
{{ param.name.lower_snake_case }}.translate_to_rpc(request.{{ param.name.lower_snake_case }})
41+
{% endif %}
42+
{% endif %}
43+
{% endfor -%}
2844
{{ name.lower_snake_case }}_stream = self._stub.Subscribe{{ name.upper_camel_case }}(request)
2945

3046
try:

0 commit comments

Comments
 (0)