switch to docker image instead of installing Mautic locally #290
+127
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
=========================================
Coverage 51.58% 51.58%
Complexity 408 408
=========================================
Files 30 30
Lines 1103 1103
=========================================
Hits 569 569
Misses 534 534 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Mar 24, 2023
53 tasks
JaZo
suggested changes
Apr 14, 2023
| strategy: | ||
| matrix: | ||
| mautic_version: ["5.x-dev", "4.x-dev"] | ||
| php_version: ["7.4", "8.0", "8.1"] |
There was a problem hiding this comment.
As per #286 PHP 7 is no longer supported.
Suggested change
| php_version: ["7.4", "8.0", "8.1"] | |
| php_version: ["8.0", "8.1"] |
| @@ -139,15 +116,17 @@ jobs: | |||
| cs: | |||
| runs-on: ubuntu-20.04 | |||
| name: CS tests | |||
| strategy: | |||
| matrix: | |||
| php_version: ["7.4", "8.0"] | |||
There was a problem hiding this comment.
Idem.
Suggested change
| php_version: ["7.4", "8.0"] | |
| php_version: ["8.0"] |
escopecz
reviewed
Apr 17, 2023
|
|
||
| php bin/console cache:clear --no-warmup | ||
|
|
||
| php bin/console mautic:install http://localhost/ --force --mailer_from_name="GitHub Actions" --mailer_from_email="github-actions@mautic.org" --mailer_transport="smtp" --mailer_host="mailhog" --mailer_port="1025" --admin_username=admin --admin_password=mautic --admin_email="bla@bla.be" |
There was a problem hiding this comment.
@mollux can you please remove the email values from this command as it will now fail due to mautic/mautic#12216
And set them in the config file directly.
54 tasks
|
@mollux some conflicts and feedback to address here. |
|
Hi @mollux there's some outstanding feedback to be addressed here from last year - could you take a look and resolve the conflicts please? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.