Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump memory limit to ensure Mautic in dev mode can handle it #301

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Apr 19, 2023

see mautic/mautic#12213 (comment)

this is most likely related tot the default memory_limit of 128M, which is not enough for the standard apache install.

This PR is a mitigation: the proper solution I'm working on is in #290

I also pushed this PR, so we can test it against the Symfony 5 PR, see the workflow: https://github.com/mautic/api-library/actions/runs/4740330977

both the workflow from this PR as the extra workflow should succeed before merging this

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2023
@mollux mollux requested a review from escopecz April 19, 2023 06:41
@mollux
Copy link
Contributor Author

mollux commented Apr 19, 2023

@escopecz both the tests for this PR as the manual run (this branch + mautic/mautic#12213) succeed

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks Mattias!

@escopecz escopecz merged commit a2f24e8 into mautic:main Apr 19, 2023
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants