Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch iterating over attributes in Safari. Fixes #10 #11

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Patch iterating over attributes in Safari. Fixes #10 #11

merged 1 commit into from
Apr 6, 2017

Conversation

bedeoverend
Copy link
Collaborator

Uses forEach rather than for...of when iterating over an element's attributes. Fixes #10 as Safari doesn't support for...of on attributes.

@bedeoverend bedeoverend self-assigned this Apr 6, 2017
matthewp
matthewp approved these changes Apr 6, 2017
View reviewed changes
Copy link
Owner

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not near a computer at the moment. Are you able to release this or do I need to? If you don't have npm publish ability yet I'll add you.

@bedeoverend bedeoverend merged commit 700ecc7 into master Apr 6, 2017
@bedeoverend bedeoverend deleted the fix-for-of-safari branch April 6, 2017 23:07
@bedeoverend
Copy link
Collaborator Author

Thanks - I don't think I can release, but I'll give it a shot and let you know if I need publish perms.

@bedeoverend
Copy link
Collaborator Author

@matthewp nah doesn't look like I've got NPM publish permission - could you give me access? Username is bede

@matthewp
Copy link
Owner

matthewp commented Apr 7, 2017

Added :)

@bedeoverend
Copy link
Collaborator Author

Ta :) Released 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees

@bedeoverend bedeoverend

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bedeoverend @matthewp