Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to upgrade added elements in Safari #10

Closed
bedeoverend opened this issue Apr 6, 2017 · 0 comments
Closed

Fails to upgrade added elements in Safari #10

bedeoverend opened this issue Apr 6, 2017 · 0 comments
Assignees
Labels

Comments

@bedeoverend
Copy link
Collaborator

When adding elements after a custom attributes has been defined, Safari kicks the bucket. See this jsbin for a repro - works in Chrome + Firefox, but not Safari.

Looks to be this line causing the problem - I think Safari musn't support for...of on NamedNodeMap? Which I think in turn means it doesn't support Symbol.Iterator on NamedNodeMap. This should mean casting attributes as an array or using the forEach helper at the top of the file should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant