New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor error code in response #2

Merged

matthewkeil merged 1 commit into matthewkeil:master from aloukissas:honor-status-code

Dec 3, 2022

Contributor

aloukissas commented Dec 3, 2022

I noticed when using the library that it would always return HTTP-200, regardless of what the lambda returns.

This PR addresses this, by (a) removing the premature res.send() and (b) replacing the res.end() with res.send().


          Honor error code in response

matthewkeil approved these changes

View reviewed changes

Owner

matthewkeil left a comment

Really EXCELLENT catch! Thank you very much for the help!

Matt
:)

matthewkeil merged commit 8133a84 into matthewkeil:master

aloukissas deleted the honor-status-code branch

December 3, 2022 01:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet