Merge pull request #2 from aloukissas/honor-status-code

Honor error code in response
matthewkeil · Dec 3, 2022 · 8133a84 · 8133a84
2 parents 31868ce + 7803364
commit 8133a84
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/convertResponse.spec.ts b/src/convertResponse.spec.ts
@@ -159,8 +159,6 @@ describe('convertResponse()', () => {
       expect(res.send).toHaveBeenCalledWith(defaultResponse.body);
       expect(res.status).toBeCalledTimes(1);
       expect(res.status).toHaveBeenCalledWith(defaultResponse.statusCode);
-      expect(res.end).toBeCalledTimes(1);
-      expect(res.end).toHaveBeenCalledWith();
     });
 
     it('should set a default statusCode', () => {

diff --git a/src/convertResponse.ts b/src/convertResponse.ts
@@ -104,10 +104,9 @@ export function convertResponseFactory({
       const coerced = isObject(response) && 'body' in response ? coerceBody(response.body) : coerceBody(response);
       logger.info('End - Result:');
       logger.info(coerced);
-      res.send(coerced);
 
       const statusCode = isObject(response) && !!response.statusCode ? parseInt(`${response.statusCode}`) : 200;
-      return res.status(statusCode).end();
+      return res.status(statusCode).send(coerced);
     } catch (error) {
       return sendError(error as Error);
     }