Add cassette motor relay sound effects to BBC Micro emulator #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the cassette motor relay "click" sound feature requested in issue #296. The BBC Micro's cassette motor relay produces distinctive click sounds when turning on and off, which are now emulated to enhance the authentic experience.
Implementation
The feature follows the existing audio architecture pattern used for disc drive sounds:
RelayNoise
class: Handles cassette relay sounds similar to the existingDdNoise
class for disc drivesAudioHandler
→ CPU constructor → ACIA, maintaining the established audio system architectureKey Changes
Acia.setMotor()
to trigger click sounds when the relay state actually changesFakeRelayNoise
Code Organization
audio-utils.js
withBaseAudioNoise
class andloadSounds
function to eliminate code duplication between disc drive and relay noise implementationsRelayNoise
(notTapeNoise
) to distinguish from actual tape audio functionality handled by the sound chip'stoneGenerator
Testing
RelayNoise
class and ACIA integrationThe sounds are currently placeholder audio files generated synthetically. As mentioned in the issue, these could be replaced with recordings from real BBC Master hardware in the future.
Fixes #296.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.