[GH-271] Updated logic for sidebar header to show assigned MRs instead of opened MRs #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…how assigned MRs instead of opened MRs (#39) * [MI-3405] Get proper data in sidebar buttons: 1. Get assigned PRs instead of the user's PRs. 2. Updated the name of sidebar buttons. 3. Updated API path. 4. Updated the name of API functions. 5. Updated the name of unreads to todos in the code. * [MI-3405] Updated name of variables and functions * [MI-3405] Updated icons in sidebar * [MI-3405] Updated documentation * [MI-3405] Reverted package-lock file changes * [MI-3405] Review fixes
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 33.21% 32.91% -0.31%
==========================================
Files 22 22
Lines 3977 4017 +40
==========================================
+ Hits 1321 1322 +1
- Misses 2525 2564 +39
Partials 131 131 ☔ View full report in Codecov by Sentry. |
hanzei
added
2: Dev Review
…ab into fix_issues_271
|
@raghavaggarwal2308 Would you please resolve the conflicts? |
…ab into fix_issues_271
|
@hanzei Resolved conflicts |
|
@hanzei @spirosoik Ready for your review |
mickmister
approved these changes
Nov 29, 2023
avas27JTG
added
3: QA Review
AayushChaudhary0001
approved these changes
Dec 19, 2023
hanzei
added
4: Reviews Complete
|
@mickmister Do we want this PR in v1.8.0? |
mickmister
added a commit
that referenced
this pull request
Jan 23, 2024
…pt (#438) * sidebar_button converted in Typescript * updated import * Some changes based on comments * Unnecessary imports removed * Updated imports * Reset the node-version to 14.21.1 * revert changes to package-lock.json --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Closed
raghavaggarwal2308
added a commit
to Brightscout/mattermost-plugin-gitlab
that referenced
this pull request
Feb 14, 2024
…how assigned MRs instead of opened MRs (#39) (mattermost#394) * [MI-3405] Get proper data in sidebar buttons: 1. Get assigned PRs instead of the user's PRs. 2. Updated the name of sidebar buttons. 3. Updated API path. 4. Updated the name of API functions. 5. Updated the name of unreads to todos in the code. * [MI-3405] Updated name of variables and functions * [MI-3405] Updated icons in sidebar * [MI-3405] Updated documentation * [MI-3405] Reverted package-lock file changes * [MI-3405] Review fixes
Merged
mickmister
added a commit
that referenced
this pull request
Feb 20, 2024
* Remove check for client secret length (#419) * support client secrets longer than 64 chars * remove length check * change client secret length check to assume at least 64 chars * change wording of error message * [GH-321]:Fixed issue #321 'Wrong notification in case of assigned prs' (#395) Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com> * [MI-3405] Fix issues #271: Sidebar header MR count should show assigned MRs instead of opened MRs (#39) (#394) * [MI-3405] Get proper data in sidebar buttons: 1. Get assigned PRs instead of the user's PRs. 2. Updated the name of sidebar buttons. 3. Updated API path. 4. Updated the name of API functions. 5. Updated the name of unreads to todos in the code. * [MI-3405] Updated name of variables and functions * [MI-3405] Updated icons in sidebar * [MI-3405] Updated documentation * [MI-3405] Reverted package-lock file changes * [MI-3405] Review fixes * [MM-42] Fix CI error: implicit memory aliasing (#429) * [MI-3588] Fix issue: Image attachment breaking in comment notification (#406) * [MI-3719] Send the users an ephemeral message if they try to connect their account via MM desktop app (#416) * [MI-3719] Send the users an ephemeral message if they try to connect their account via MM desktop app * [MI-3713] Handles the following cases as well for desktop app: 1. Connecting using the button from the teams sidebar. 2. Connecting using the button from RHS. * [MI-3719] Review fixes * [MI-3719] Review fixes Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * [MI-3719] Fix lint error --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Fix lint errors * Update plugin version --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
Screenshots
Before:
After:
Ticket Link
Fixes #271