Wrong notification saying "X assigned you to merge request" when the issue is updated (e.g., new commits pushed)

[wkentaro]

This seems to be a known issue, but can anyone guide me to resolve this?
It is a bit annoying to get notification every time someone pushes a new commit.

[mickmister]

Hi @wkentaro! It looks like this may be possible via event.Changes.Assignee.Previous and event.Changes.Assignee.Current. We can diff these two arrays to find if there is a new assignee. Then we can DM the new assignee(s) if there is one. Would you be interested in implementing this?

https://github.com/xanzy/go-gitlab/blob/6da2d13f2241eab2edf52f881b28a31595780a7e/event_webhook_types.go#L557-L561

[wkentaro]

Yes, I'm happy to.

One thing that is blocking me to do so is that it is not very clear to me if xxxUsername variables point the username of Gitlab or Mattermost, and I'm not sure how I can easily test that. (Do you know these?)

mattermost-plugin-gitlab/server/webhook/merge_request.go

Lines 23 to 24 in 1a620e3

	authorGitlabUsername := w.gitlabRetreiver.GetUsernameByID(event.ObjectAttributes.AuthorID)
	senderGitlabUsername := event.User.Username

Looking at the messages, it looks like they are the username of Gitlab.

mattermost-plugin-gitlab/server/webhook/merge_request.go

Lines 32 to 37 in 1a620e3

	message = fmt.Sprintf("[%s](%s) requested your review on [%s!%v](%s)", senderGitlabUsername, w.gitlabRetreiver.GetUserURL(senderGitlabUsername), event.ObjectAttributes.Target.PathWithNamespace, event.ObjectAttributes.IID, event.ObjectAttributes.URL)
	case actionReopen:
	message = fmt.Sprintf("[%s](%s) reopen your merge request [%s!%v](%s)", senderGitlabUsername, w.gitlabRetreiver.GetUserURL(senderGitlabUsername), event.ObjectAttributes.Target.PathWithNamespace, event.ObjectAttributes.IID, event.ObjectAttributes.URL)
	case actionUpdate:
	// TODO not enough check (opened/update) to say assigned to you...
	message = fmt.Sprintf("[%s](%s) assigned you to merge request [%s!%v](%s)", senderGitlabUsername, w.gitlabRetreiver.GetUserURL(senderGitlabUsername), event.ObjectAttributes.Target.PathWithNamespace, event.ObjectAttributes.IID, event.ObjectAttributes.URL)

But these variables are used for sending messages to ToUsers

mattermost-plugin-gitlab/server/webhook/merge_request.go

Lines 48 to 53 in 1a620e3

	handlers := []*HandleWebhook{{
	Message: message,
	ToUsers: []string{w.gitlabRetreiver.GetUsernameByID(event.ObjectAttributes.AssigneeID), authorGitlabUsername},
	ToChannels: []string{},
	From: senderGitlabUsername,
	}}

so I wonder if it is also somehow related to the one for Mattermost?

---

It seems most likely they are the username of Gitlab, so I can do something like below:

if authorGitlabUsername in event.Changes.Assignee.Current and \
       authorGitlabUsername not in event.Changes.Assignee.Previous:
   toUsers.append(authorGitlabUsername)

[ashutosh887]

Let me work on this @wkentaro

[mickmister]

Hi @ashutosh887, sorry for the late response here. Are you still interested in working on this?

[mickmister]

@mkdbns Heads up that a customer has pointed this out, so I'm adding to the plugin maintenance board. Also here's a thread with some discussion on this https://community.mattermost.com/core/pl/bk4z76cqm3dxprcpf536jb3gwr

[mickmister]

Note the open PR that seems that it's no longer being worked on here #324

[tschuyebuhl]

is this still up for grabs?

[mickmister]

Indeed it is @tschuyebuhl. Let me know if you'd like to work on it, and I can assign it to you 👍

[tschuyebuhl]

yeah, I would love to work on it if it's not a problem