Fixed GH-107: synched ./build in starter-template #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also removed the golint target from Makefile since it's failing and I don't see a way to customize its checks
hanzei
reviewed
Oct 3, 2019
|
@levb Why is this needed for 5.16? |
Merged
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
@levb Gentle reminder about this PR |
added 2 commits
October 29, 2019 12:04
…ab into lev-GH-107-errcheck
Also Go 1.13 compatible/tidy
|
should be ready to go, builds here and locally with go 1.13.3; @hanzei sorry about the errcheck confusion. |
hanzei
approved these changes
Nov 9, 2019
cpoile
approved these changes
Nov 9, 2019
levb
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't see a way to customize its checks
Fixes #107