Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped release to 1.0.1 #105

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Bumped release to 1.0.1 #105

merged 2 commits into from
Oct 10, 2019

Conversation

levb
Copy link
Contributor

@levb levb commented Sep 29, 2019

To be included with the 5.16 release

@levb levb added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 29, 2019
Copy link
Contributor

@manland manland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@levb levb requested a review from hanzei September 30, 2019 13:36
@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Sep 30, 2019
@DHaussermann
Copy link

@levb I can't run the full make file on this. I get the following:

Running errcheck
env GO111MODULE=off /usr/local/go/bin/go get github.com/kisielk/errcheck
errcheck ./server/... 

Used make dist to only build the package and version bump was successful. Please advise if there is a separate issue that must be resolved with the make instructions.

@levb
Copy link
Contributor Author

levb commented Sep 30, 2019

@levb I can't run the full make file on this. I get the following:

Running errcheck
env GO111MODULE=off /usr/local/go/bin/go get github.com/kisielk/errcheck
errcheck ./server/... 

Used make dist to only build the package and version bump was successful. Please advise if there is a separate issue that must be resolved with the make instructions.

@manland Do you know if it's a regression, or did make all just fall out of date, and should be fixed? (as a separate issue?)

@manland
Copy link
Contributor

manland commented Oct 1, 2019

@levb make all worked 19 days ago when I push this

But, make was not working since introduction of custom build because the first rule isn't all but errcheck. I had forgotten to open an issue about that 😓

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 1, 2019
@DHaussermann
Copy link

Created issue here: #107 to address this before release.

@levb levb self-assigned this Oct 8, 2019
@levb
Copy link
Contributor Author

levb commented Oct 10, 2019

@DHaussermann I am stuck figuring out why all these checkers don't work, but let's not hold the release for it any longer, I'd like to prep it for 5.15 and these tooling issues are hardly a showstopper (#108).

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @levb

The make file issue had no functional impact and we have an issue to address it later.

LGTM!

@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 10, 2019
@levb levb merged commit 16411af into mattermost:master Oct 10, 2019
@levb levb deleted the levb-bump-release branch October 10, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants