Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport github plugin improvements #61

Closed
5 tasks
manland opened this issue Jun 5, 2019 · 1 comment · Fixed by #299, #300 or #306
Closed
5 tasks

Backport github plugin improvements #61

manland opened this issue Jun 5, 2019 · 1 comment · Fixed by #299, #300 or #306
Labels
Hacktoberfest Help Wanted Community help wanted Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone
Planned Work

Comments

@manland
Copy link
Contributor

manland commented Jun 5, 2019 •
edited by hanzei
Loading

@hanzei hanzei added Enhancement Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jun 21, 2019
@hanzei hanzei added Type/Task A general task and removed Enhancement labels Mar 7, 2020
@hanzei hanzei added this to the v1.5.0 milestone Feb 1, 2022
@hanzei hanzei self-assigned this Feb 8, 2022
@hanzei
Copy link
Collaborator

hanzei commented Feb 8, 2022

@hanzei to update the list

@hanzei hanzei modified the milestones: v1.5.0, v1.6.0 Feb 10, 2022
@hanzei hanzei removed their assignment Mar 15, 2022
@shivamjosh shivamjosh mentioned this issue Jun 2, 2022
Merged
@raghavaggarwal2308 raghavaggarwal2308 mentioned this issue Jun 3, 2022
Merged
@shivamjosh shivamjosh mentioned this issue Jun 6, 2022
Merged
@raghavaggarwal2308 raghavaggarwal2308 mentioned this issue Jun 20, 2022
Merged
@hanzei hanzei modified the milestones: v1.6.0, Planned Work Nov 29, 2022
hanzei pushed a commit that referenced this issue Mar 2, 2023
@raghavaggarwal2308 @manojmalik20 @ayusht2810
[GH-61]: RHS Support (#300)
d041aba 
* Added RHS support to gilab plugin. (#1)

* Added RHS Support
1. Opening right hand sidebar onclick of LHS buttons.
2. Displaying users merge requests, assignments, reviews and todos.
3. Displaying Labels on reviews , merge requests and assignments.

* Adding RHS to gitlab
1. Displaying unread todos in RHS.

* Review fixes
1. String in sigle quotes.
2. indentation.
3.removing extra spaces

* Review Fixes
1. Fixing dependencies.
2. Adding EOF.

* used string literals

* use nullish coalescing operator

* Error in api
1. Error while fetching reviews and pr's.

* review fixes

* review fixes

* Review fixes.
1. Upgraded dependency versions.
2. Convertes sider_right.jsx to .tsx

* Fixed linting errors and changed some eslint config
Added a new dependency eslint-plugin-react-hooks and used that in .eslintrc.json
Added some new rules in eslintrc related to typescript from the Github plugin

* Fixed some more spacing issues

* Apply suggestions from code review

* Review fixes
1. Upgraded mattermost-redux version.
2. Moved constants.

* Changed file extensions

Co-authored-by: Manoj <manoj@brightscout.com>

* Fix label details issue (#6)

* Fixed issue with label details
1. Created a new func to get label details from api

* Moved struct to top of file

* Review fixes
1. Added logic to get label details in "yourAssignments" func.

* Fixes name of struct

* Fixed names of variables

* Update RHS UI (#3)

* Added RHS Support
1. Opening right hand sidebar onclick of LHS buttons.
2. Displaying users merge requests, assignments, reviews and todos.
3. Displaying Labels on reviews , merge requests and assignments.

* Adding RHS to gitlab
1. Displaying unread todos in RHS.

* Review fixes
1. String in sigle quotes.
2. indentation.
3.removing extra spaces

* Displayed PR status

* Improving RHS UI
1. Added status icon to PR's and reviews.
2. Added details of how many reviewers approved the PR.

* fixed error in command_test file

* Review Fixes
1. Fixing dependencies.
2. Adding EOF.

* used string literals

* use nullish coalescing operator

* Error in api
1. Error while fetching reviews and pr's.

* review fixes

* review fixes

* Review fixes.
1. Upgraded dependency versions.
2. Convertes sider_right.jsx to .tsx

* Fixed issue with label details
1. Created a new func to get label details from api

* Review fixes
1. Fixed warning in "npm run lint" command
2. Logged error while fetching pr details.
3. Removed extra variables.

* Indentation fixes

* Added space after semicolons

* Review fixes
1. Added label details functionality to assignments.
2. Fixed error messages.

* Review fixes
1. Removed trailing spaces.
2. Removed logger.Logger from "fetchPrDetails" func.

* Review fixes
1. Fixed spacing in error message.

* Review fixes
1. Passed logger to function

* Fixed linting error

* [MI-1823 & MI-1839]Review fixes for PR in mattermost
1. Defined abdolute paths.
2. Fixed indentation.
3. Removed redundant code.
4. Defined constants for strings.

* [MI-1823]Indentation fix and removed white space

* Review fix: Added blank line in gitlab_items.tsx

* [MI-1823]Fixed getReviews api
1. Get reviews api was fetching merge requests assigned to the user. Fixed it to fetch the merge requests in which user is added as a reviewer.

* Review fixes

* [MI-1957] Review fixes of RHS support PR (#14)

* [MI-1957] Do review fixes

* [MI-1957] Self review fixes

* [MI-1957] Bug fix

* [MI-1957] Review fixes 1

* [MI-1957] Review fix 2

* [MI-1957] Review fix

* [MI-1957] Review fixes 3

* [MI-1957] Add eof

* [MI-1957] Correct translations

* [MI-1957] Review fix

* [MI-1957] Add a comment

* [MI-1957] Correct comment

* [MI-1957] Review fixes

* [MI-2024] Gitlab PR review fixes (#19)

* [MI-2024] Gitlab PR review fixes

* [MI-2024] Fix error

* [MI-2024] Review fix

* [MI-2024] Revert changes

* [MI-2024] Review fixes

* Fix a constant for storing author

* [MI-2389] Fix review fixes for PR rhs support

* [MI-2389] Update a comment

* [MI-2407] Review fixes for PR rhs support

* [MI-2433] Review fixes
1. Removed extra useEffect for componentDidMount

* [MI-2433] Review fixes
1. Created a generic usePrevious hook

* Fix lint errors

* [MI-2595] Review fixes on Gitlab PR #300 (Add RHS Support)

* [MI-2845] Added space after link in RHS card.

---------

Co-authored-by: Manoj <manoj@brightscout.com>
Co-authored-by: ayusht2810 <100013900+ayusht2810@users.noreply.github.com>
Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
raghavaggarwal2308 added a commit to Brightscout/mattermost-plugin-gitlab that referenced this issue May 7, 2023
@raghavaggarwal2308
[mattermostGH-61] Updated description of EnablePrivateRepos config se…
c1cf8f9 
…tting.
hanzei pushed a commit that referenced this issue Jun 19, 2023
@shivamjosh @raghavaggarwal2308
@Nityanand13 @Kshitij-Katiyar @manojmalik20
[GH-61]: Show code block previews of Gitlab permalinks (#299)
842c6b3 
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Co-authored-by: Nityanand Rai <nityanand.rai@brightscout.com>
Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com>
Co-authored-by: Manoj <manoj@brightscout.com>
Co-authored-by: Nityanand13 <107465508+Nityanand13@users.noreply.github.com>
avas27JTG pushed a commit that referenced this issue Nov 29, 2023
@shivamjosh @raghavaggarwal2308 @Nityanand13
[GH-61]: Add tooltip for pull request and issue links (#301)
b5184fa 
* MI-1845: Added tooltip for pull request and issue links

* MI-1845: Done review fixes

* Added the verbose flag to the npm install command in Makefile to fix failing CI

* Fixed lint errors

* Added regex for url valiation and constants for link types and states

* Fixed linting errors

* Removed unnecessary escape character

* Minor code improvement

* Fixed CI lint error

* Added babel config for optional chaining

* Added missing trailing comma

* Fixed typo

* [MI-1919] Fixes issue in link tooltip
1. Heading and description text overlays in tooltip when crosses a certain limit

* [MI-1995] Fixed failing CI in link tooltip PR
1. Fixed the error "'gitlab.com' can be anywhere in the URL, and arbitrary hosts may come before or after it."

* Fixed spacing around 'on' using js instead of using css

* [MI-2755] Review fixes on gitlab PR #301

* [MI 2837]: Done the review fixes of a gitlab PR #301 (#30)

* [MI-2837] Review fixes on gitlab PR #301

* [MI-2837]: Review fixes done
1. Written the test cases properly

* [MI-2837]: Review fixes done
1. Improved code readability
2. Improved code consistency

* [MI-2837]: Review fixes done
1. Improved code quality

* [MI-2937]: Added EOF

* [MI-2837]: Review fixes done
1. Improved code readability

---------

Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2963]: Did the review fixes of gitlab PR #301 (#32)

* [MI-2963]: Did the review fixes of gitlab PR #301
1.Improved the unit tests
2.Improved the code readability

* [MI-2963]: Fixed linting error

* [MI-2963]: Review fixes done
1. Improved unit tests

* [MI-2963]: Review fixes done
1. Added default in switch cases

* [MI-2963]: Review fixes done
1. Dispatched the error

* [MI-2963]: Review fixes done
1. Improved code readability

* [MI-2963]:Review fixes done
1. Improved code readability

* [MI-2963]: Review fxes done
1. Improved the description of a unit test

* [MI-2986] Review fixes on Gitlab PR #301(Add link tooltip)
1. Replaced the deprecated icon component.
2. Added a return statement to avoid unnecessary code execution.

---------

Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Co-authored-by: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
raghavaggarwal2308 added a commit that referenced this issue Jul 18, 2024
@raghavaggarwal2308 @Nityanand13 @ayusht2810
[GH-61]: Adding "Create Issue" and "Attach Comment to Issue" modals (#…
c7208c0 
…306)

* [MI-1847] Created new branch for create-issue-modal

* [MI-1847] fixed error while running make check-style

* [MI-1847]Review fixes
1. Converted files to .tsx
2. Defined proper types

* [MI-1847]Fixed initial srtate of milestone in create_issue.tsx

* [MI-1860]Added attach comment to gitlab issue button

* [MI-1860]Added "Attach to gilab issue" modal
1. Button in context menu to open "Attach to gitlab issue" modal.
2. Created modal to attach comment to issue.

* [MI-1860]Attach comment endpoint
1. Created api endpoint to attach comment to an issue.

* [MI-1860]Added post message
1. Added message when comment is created.

* [MI-1860]Handled error
1. Handled error while making call for searching issues.

* Code formatting
1. Converted file to .tsx.
2. Removed redundant code.

* Merge branch 'MI-1847' of github.com:Brightscout/mattermost-plugin-gitlab into MI-1860

* [MI-1860]Pull from MI-1847
1. Fixed error messages.

* removed //eslint-diable...

* [MI-1860]Review fixes
1. Made first letter of error lowercase
2. Used shorthand
3. fixed lint errors

* Merge branch 'MI-1847' of github.com:Brightscout/mattermost-plugin-gitlab into MI-1860
Review fixes:
1. Defined types and converted files to .tsx

* [MI-1860]Review Fixes
1. Defined proper types
2. Changed file extension of types file to .d.ts

* [MI-1860]Fixes
1. Corrected error messages in api.go.
2. Added EOF.

* [MI-1847] Review fixes
1. Moved type "Actions" from index.ts to main file.
2. Converted form_button to fuctional component.
3. Converted gitlab.jsx to .tsx.

* [MI-1847]Review Fixes
1. Converted gitlab.tsx to funtional component.
2. Optional chaining while checking for error in loadoptions function.

* Fixed CI error
1. Added "react-dom" dependency in package.json

* [MI-1847]Fixes
1. Converted class components to functional components.
2. Used absolute paths.

* [MI-1847]Review FIxes
1. Removed mapStateToProps/mapDispatchToProps from functional components and used useSelector/useDispatch.

* [MI-1860]Review fixes
1. Converted functional componets to class components.
2. used useCallback and useMemo hook.
3. Returned proper status codes.
4. Used absolute paths for imports.

* [MI-1847]Review fixes
1. Used BotID for creating post.
2. Used useCallback hooks.
3. Fixed linting errors.

* [MI-1847]Converted remaining class components to functional components

* [MI-1860]Fixed variable names

* [MI-1847]Review fixes
1. Creates a single type for state - "GlobalState".
2. Converted proptypes from interface to type.

* [MI-1847]Review fixes
1. Created a hook for getting assignees, milestones and labels.

* [MI-1847]Review fixes
1. Removed any type.

* [MI-1860]Review fixes
1.Used use callback hook.

* [MI-1860]Review fixes
1. Used useMemo and useCallback.
2. Destructured props.

* [MI-1860]Review Fixes
1. Changed name of a variable.

* [MI-2221] Review fixes (#22)

* [MI-2245] Fix failing "Code scanning / CodeQL" in gitlab create issue modal PR (#23)

[MI-2245] Fix failing "Code scanning / CodeQL" in GitLab create issue modal PR

* Fix lint errors

* [MI-2701]: Done the review fixes of a PR: Adding create issue modal #306 (#28)

* [MI-2701]: Done the review fixes of a PR: Adding create issue modal #306

* [MI-2701]: Review fixes done
1. Used actual gitlab icon

* [MI-2701]: Review fixes done
1. Improved the gitlab icon

* [MI-2701]: Review fixes done
1. Updated the viewbox

* [MI-2947]: Did the review fixes of a gitlab PR #306 (#31)

* [MI-2967]: Did the review fixes of gitlab PR #306 (#33)

* [MI-2967]: Did the review fixes of gitlab PR #306

* [MI-2967]: Improved code readability

* [MI-2967]: Review fixes done
1. Changed the name of a variable

* [MI-2959] Review fixes on Gitlab PR #306(Add create issue modal)
1. Fixed theme issue in post action menu.
2. Fixed the max length of issue title.
3. Added check to display the projects of connected gitlab group only.
4. Added check to display the issues of connected gitlab group only.

* [MI-3787] Fix reported issue:
- Hide the additional fields in create issue modal if the selected priject is removed.

* [MM-3] Removed "ussCallback" and "useMemo" hooks

* [MM-3] Removed useMemo/useCallabck and fixed lint error.

* [MM-3] Separated out form components for create issue modal

* [MM-3] Seperate out form component for attach comment to issue modal

* Fix lint errors

* [MM-158] Review fixes
1. Rename types
2. Create selectors for modal visibility vars
3. Fix warnings in console

* [MM-158] Review fixes:
1. Mode the footer part to form components
2. Create selectors for getting modal contents
3. Make the meesage field in attach comment modal as editable and added validation

* [MM-158] Review fixes:
1. Create a common file for types.
2. Moved the modal form components to modals directory.

* [MM-146] Fixed lint errors

* [MM-289] Fix ci error

* Review fixes: Add new types, error state and some refactoring

* Fix package-lock.json file

* [MM-527] Review fixes

* Create a new type

* Update package-lock.json file due to ci errors

* Fix type errors

---------

Co-authored-by: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Help Wanted Community help wanted Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
Planned Work
4 participants
@jespino @manland @cpanato @hanzei