Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always send refresh for author refresh in web hook #19

Closed
manland opened this issue Apr 26, 2019 · 0 comments · Fixed by #25
Closed

Always send refresh for author refresh in web hook #19

manland opened this issue Apr 26, 2019 · 0 comments · Fixed by #25
Assignees
@manland

Comments

@manland
Copy link
Contributor

manland commented Apr 26, 2019

Add default :

return []*HandleWebhook{{From: senderGitlabUsername}}, nil

to all web hook handler to refresh left summary compo for author
@manland manland added the bug label Apr 26, 2019
@manland manland self-assigned this May 1, 2019
@manland manland mentioned this issue May 1, 2019
Merged
hanzei pushed a commit that referenced this issue Mar 2, 2023
@raghavaggarwal2308 @manojmalik20 @ayusht2810
[GH-61]: RHS Support (#300)
d041aba 
* Added RHS support to gilab plugin. (#1)

* Added RHS Support
1. Opening right hand sidebar onclick of LHS buttons.
2. Displaying users merge requests, assignments, reviews and todos.
3. Displaying Labels on reviews , merge requests and assignments.

* Adding RHS to gitlab
1. Displaying unread todos in RHS.

* Review fixes
1. String in sigle quotes.
2. indentation.
3.removing extra spaces

* Review Fixes
1. Fixing dependencies.
2. Adding EOF.

* used string literals

* use nullish coalescing operator

* Error in api
1. Error while fetching reviews and pr's.

* review fixes

* review fixes

* Review fixes.
1. Upgraded dependency versions.
2. Convertes sider_right.jsx to .tsx

* Fixed linting errors and changed some eslint config
Added a new dependency eslint-plugin-react-hooks and used that in .eslintrc.json
Added some new rules in eslintrc related to typescript from the Github plugin

* Fixed some more spacing issues

* Apply suggestions from code review

* Review fixes
1. Upgraded mattermost-redux version.
2. Moved constants.

* Changed file extensions

Co-authored-by: Manoj <manoj@brightscout.com>

* Fix label details issue (#6)

* Fixed issue with label details
1. Created a new func to get label details from api

* Moved struct to top of file

* Review fixes
1. Added logic to get label details in "yourAssignments" func.

* Fixes name of struct

* Fixed names of variables

* Update RHS UI (#3)

* Added RHS Support
1. Opening right hand sidebar onclick of LHS buttons.
2. Displaying users merge requests, assignments, reviews and todos.
3. Displaying Labels on reviews , merge requests and assignments.

* Adding RHS to gitlab
1. Displaying unread todos in RHS.

* Review fixes
1. String in sigle quotes.
2. indentation.
3.removing extra spaces

* Displayed PR status

* Improving RHS UI
1. Added status icon to PR's and reviews.
2. Added details of how many reviewers approved the PR.

* fixed error in command_test file

* Review Fixes
1. Fixing dependencies.
2. Adding EOF.

* used string literals

* use nullish coalescing operator

* Error in api
1. Error while fetching reviews and pr's.

* review fixes

* review fixes

* Review fixes.
1. Upgraded dependency versions.
2. Convertes sider_right.jsx to .tsx

* Fixed issue with label details
1. Created a new func to get label details from api

* Review fixes
1. Fixed warning in "npm run lint" command
2. Logged error while fetching pr details.
3. Removed extra variables.

* Indentation fixes

* Added space after semicolons

* Review fixes
1. Added label details functionality to assignments.
2. Fixed error messages.

* Review fixes
1. Removed trailing spaces.
2. Removed logger.Logger from "fetchPrDetails" func.

* Review fixes
1. Fixed spacing in error message.

* Review fixes
1. Passed logger to function

* Fixed linting error

* [MI-1823 & MI-1839]Review fixes for PR in mattermost
1. Defined abdolute paths.
2. Fixed indentation.
3. Removed redundant code.
4. Defined constants for strings.

* [MI-1823]Indentation fix and removed white space

* Review fix: Added blank line in gitlab_items.tsx

* [MI-1823]Fixed getReviews api
1. Get reviews api was fetching merge requests assigned to the user. Fixed it to fetch the merge requests in which user is added as a reviewer.

* Review fixes

* [MI-1957] Review fixes of RHS support PR (#14)

* [MI-1957] Do review fixes

* [MI-1957] Self review fixes

* [MI-1957] Bug fix

* [MI-1957] Review fixes 1

* [MI-1957] Review fix 2

* [MI-1957] Review fix

* [MI-1957] Review fixes 3

* [MI-1957] Add eof

* [MI-1957] Correct translations

* [MI-1957] Review fix

* [MI-1957] Add a comment

* [MI-1957] Correct comment

* [MI-1957] Review fixes

* [MI-2024] Gitlab PR review fixes (#19)

* [MI-2024] Gitlab PR review fixes

* [MI-2024] Fix error

* [MI-2024] Review fix

* [MI-2024] Revert changes

* [MI-2024] Review fixes

* Fix a constant for storing author

* [MI-2389] Fix review fixes for PR rhs support

* [MI-2389] Update a comment

* [MI-2407] Review fixes for PR rhs support

* [MI-2433] Review fixes
1. Removed extra useEffect for componentDidMount

* [MI-2433] Review fixes
1. Created a generic usePrevious hook

* Fix lint errors

* [MI-2595] Review fixes on Gitlab PR #300 (Add RHS Support)

* [MI-2845] Added space after link in RHS card.

---------

Co-authored-by: Manoj <manoj@brightscout.com>
Co-authored-by: ayusht2810 <100013900+ayusht2810@users.noreply.github.com>
Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manland manland

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@manland