[MM-57194] Mark confidential settings as secrets #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
hanzei
force-pushed
the
MM-57194_support-packet_plugin-secrets
branch
from
f3d7ee4
to
65fa789
Compare
wiggin77
reviewed
Aug 15, 2024
AayushChaudhary0001
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
This PR has been tested with the help of mattermost/mattermost#27986 as it requires some changes in the server.
All the secrets and keys are shown encrypted in the plugin settings, LGTM. Approved.
hanzei
added
4: Reviews Complete
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make use of mattermost/mattermost#27986 by marking the following config settings as secrets:
GitHubOAuthClientSecretWebhookSecretEncryptionKeyThe other changes are needed due to the breaking changes in mattermost/mattermost#26471.
GitHubOAuthClientIDis shown in plain text in the GitHub UI, so I don't think it needs to be obfuscated.Ticket Link
https://mattermost.atlassian.net/browse/MM-57194