Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57194] Mark confidential settings as secrets #522

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[MM-57194] Mark confidential settings as secrets #522

merged 3 commits into from
Oct 1, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Sep 12, 2024 •
edited
Loading

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 12, 2024
@hanzei hanzei marked this pull request as ready for review September 13, 2024 07:23
wiggin77
wiggin77 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 16, 2024
@hanzei
Copy link
Collaborator Author

hanzei commented Sep 23, 2024

@AayushChaudhary0001 Would you mind giving this PR a review?

@Kshitij-Katiyar
Copy link
Contributor

Hey @hanzei, just a quick question
Are the changes in the flow manager-related files related to the task of marking confidential settings as a secret?

@hanzei
Copy link
Collaborator Author

hanzei commented Sep 23, 2024

@Kshitij-Katiyar No, they are required because the PR updates github.com/mattermost/mattermost/server/public

@hanzei
Copy link
Collaborator Author

hanzei commented Sep 25, 2024

FYI: I copied over the changes from mattermost/mattermost-plugin-github#827

AayushChaudhary0001
AayushChaudhary0001 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for secrets in plugin configs which get encrypted according to the changes in this PR. Also, the user is able to connect the user and rest basic functionalities work fine for the plugin, LGTM. Approved.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 1, 2024
@hanzei hanzei merged commit aefdbd2 into master Oct 1, 2024
7 checks passed
@hanzei hanzei deleted the MM-57194_support-packet_plugin-secrets branch October 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@Kshitij-Katiyar Kshitij-Katiyar Kshitij-Katiyar approved these changes

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@spirosoik spirosoik Awaiting requested review from spirosoik spirosoik is a code owner

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @Kshitij-Katiyar @wiggin77 @AayushChaudhary0001