Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Create and Attach does not show results when org lock is set to a user's workspace #548

Closed
DHaussermann opened this issue Mar 7, 2022 · 4 comments
Labels
Type/Bug Something isn't working

Comments

@DHaussermann
Copy link

When the Organization lock is set to a user's workspace such as DHaussermann, the create and attach modal will not show any results.
If the org lock is set to an actual organization such as dkh-org the functionality seems to work as expected.

image

{"timestamp":"2022-03-07 13:50:37.916 Z","level":"info","msg":"Metrics endpoint is initiated","caller":"metrics/metrics.go:882","address":":8067"}
{"timestamp":"2022-03-07 13:50:37.918 Z","level":"info","msg":"Metrics and profiling server is stopping","caller":"app/server.go:1572"}
{"timestamp":"2022-03-07 13:50:37.918 Z","level":"info","msg":"Metrics endpoint is initiated","caller":"metrics/metrics.go:882","address":":8067"}
{"timestamp":"2022-03-07 13:50:37.918 Z","level":"info","msg":"Metrics and profiling server is started","caller":"app/server.go:1660","address":"[::]:8067"}
{"timestamp":"2022-03-07 13:50:49.857 Z","level":"warn","msg":"Failed to list repositories by org","caller":"app/plugin_api.go:934","plugin_id":"github","userid":"79wpfnw78jdeijyz3ow31epj1c","github username":"DHaussermann","error":"GET https://api.github.com/orgs/DHaussermann/repos?per_page=50&sort=full_name: 404 Not Found []"}
{"timestamp":"2022-03-07 13:50:49.995 Z","level":"info","msg":"This node attempted to join the cluster, but could not find any nodes.","caller":"cluster/cluster.go:391"}
{"timestamp":"2022-03-07 13:50:55.249 Z","level":"warn","msg":"Build number is not in semver format","caller":"app/product_notices.go:100","build_number":""}
{"timestamp":"2022-03-07 13:50:59.230 Z","level":"warn","msg":"Failed to list repositories by org","caller":"app/plugin_api.go:934","plugin_id":"github","userid":"79wpfnw78jdeijyz3ow31epj1c","github username":"DHaussermann","error":"GET https://api.github.com/orgs/DHaussermann/repos?per_page=50&sort=full_name: 404 Not Found []"}
{"timestamp":"2022-03-07 13:51:04.993 Z","level":"warn","msg":"Feature NormalizeLdapDNs not found, returning control.","caller":"featureflag/split_logger.go:21","service":"split"}

-This differs from the subscription logic which does not seem to make a distinction between if the org lock is set to an actual organization or not.

  • This issue reproduces on the latest production build v2.0.1

Steps:

  • Enable the plugin and connect a test user
  • Set a GitHub user's workspace such as DHaussermann (This may require a webapp refresh. There is an issue documented for this)
  • Make a post and open the connect or attach modal
    Observed Repository list stays empty and dev console shows a 500 error
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Mar 7, 2022
@DHaussermann
Copy link
Author

@dipak-demansol FYI I have documented the issue you found.

@catalintomai
Copy link

Assigned to Raju for re-assignment (if needed).

@sibasankarnayak
Copy link
Contributor

@DHaussermann what is the expected behaviour , when we do lock it to workspace it is not a valid org so it throws error

@Kshitij-Katiyar
Copy link
Contributor

@hanzei @DHaussermann I am thinking that if somebody has put a username in the org lock field. The correct behavior should be that the user should be able to see the repo associated with that username or the requirement is something else.
Please share you views

@mkdbns mkdbns moved this from Todo to In Progress in Brightscout Plugin Maintenance Mar 14, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Mar 20, 2023
#23)

* [MI-2872]:Fixed issue mattermost#548 on github 'org loack for username'

* [MI-2872]:Fixed lint errors

* [MI-2872]:Fixed review comments

* [MI-2872]:Fixed review commets
@hanzei hanzei moved this from In Progress to Done in Brightscout Plugin Maintenance Mar 23, 2023
@hanzei hanzei moved this from Done to Submitted in Brightscout Plugin Maintenance Mar 23, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Mar 24, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Mar 24, 2023
…#548 (#27)

* [MI-2929]:Fixed review comments given by mm team for issue mattermost#548

* [MI-2929]:Fixed review comment
mickmister pushed a commit that referenced this issue Apr 11, 2023
…g' (#658)

* [MI-2872]:Fixed issue #548 on github 'org lock for username' (#23)

* [MI-2872]:Fixed issue #548 on github 'org loack for username'

* [MI-2872]:Fixed lint errors

* [MI-2872]:Fixed review comments

* [MI-2872]:Fixed review commets

* [MI-2929]:Fixed review comments given by mm team for issue #548 (#27)

* [MI-2929]:Fixed review comments given by mm team for issue #548

* [MI-2929]:Fixed review comment

* [MM-548]:Fixed review comments
trilopin added a commit that referenced this issue Apr 17, 2023
* master:
  [MM-50985] Remove usage of model.AppError (#648)
  [GH-548]:Fixed issue #548 on github 'org lock for username not working'  (#658)
@hanzei hanzei closed this as completed May 21, 2023
@github-project-automation github-project-automation bot moved this from Submitted to Done in Brightscout Plugin Maintenance May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
Development

No branches or pull requests

6 participants