[MI-2929]:Fixed review comments given by mm team for issue #548 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshitij-Katiyar
changed the title
manojmalik20
approved these changes
Mar 24, 2023
Kshitij-Katiyar
added a commit
that referenced
this pull request
Apr 14, 2023
… username not working' (mattermost#658) * [MI-2872]:Fixed issue mattermost#548 on github 'org lock for username' (#23) * [MI-2872]:Fixed issue mattermost#548 on github 'org loack for username' * [MI-2872]:Fixed lint errors * [MI-2872]:Fixed review comments * [MI-2872]:Fixed review commets * [MI-2929]:Fixed review comments given by mm team for issue mattermost#548 (#27) * [MI-2929]:Fixed review comments given by mm team for issue mattermost#548 * [MI-2929]:Fixed review comment * [MM-548]:Fixed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mattermost#658