fix entry logic to not re-fetch data for the initial team #8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
rahimrahman
approved these changes
Nov 18, 2024
Comment on lines
-293
to
-297
| // this is to keep backwards compatibility with servers that send the | ||
| // threads for DM / GM regardless for every team | ||
| const version = await getConfigValue(database, 'Version'); | ||
| const hasThreadExclusions = isMinimumServerVersion(version, 10, 2, 0); | ||
|
|
There was a problem hiding this comment.
I can understand changes in the file /actions/remote/entry/common.ts, but what do these changes have anything to do with not re-fetching data for the initial team?
There was a problem hiding this comment.
The initial team selected first is already fetching its data, here we were not filtering this fetching the same data again
larkox
approved these changes
Nov 18, 2024
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 59a49b3)
mattermost-build
added
CherryPick/Done
enahum
pushed a commit
that referenced
this pull request
Nov 18, 2024
larkox
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We made some improvements to the performance of login here #8306 but there were two bugs that are fixed in this PR.
Ticket Link
N/A
Release Note