Login improvement #8306
Merged
Login improvement #8306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
commented
Nov 1, 2024
| @@ -6,7 +6,7 @@ import React | |||
| @objc private var hasRegisteredLoad = false | |||
|
|
|||
| deinit { | |||
| DispatchQueue.main.async { | |||
| DispatchQueue.main.sync { | |||
There was a problem hiding this comment.
this change fixes a crash when reloading the app in dev mode.
enahum
commented
Nov 1, 2024
| @@ -60,7 +60,7 @@ class NetworkManager { | |||
| sessionConfiguration: { | |||
| allowsCellularAccess: true, | |||
| waitsForConnectivity: false, | |||
| httpMaximumConnectionsPerHost: 10, | |||
| httpMaximumConnectionsPerHost: 100, | |||
There was a problem hiding this comment.
this change increases the amount of concurrent requests that can be perform for each server, specially significant on Android
enahum
commented
Nov 1, 2024
larkox
approved these changes
Nov 4, 2024
larkox
approved these changes
Nov 4, 2024
|
@rahimrahman how are we with the review? |
amyblais
added
the
CherryPick/Approved
rahimrahman
approved these changes
Nov 13, 2024
enahum
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Nov 13, 2024
* refactor to improve requests on login * include in team sidebar order by display name teams not present in the order preference * Fix iOS reload while developing * fix code causing tests to fail * feedback review * update network-client (cherry picked from commit ea2cb45)
mattermost-build
added
the
CherryPick/Done
mattermost-build
removed
the
CherryPick/Approved
enahum
added a commit
that referenced
this pull request
Nov 13, 2024
* refactor to improve requests on login * include in team sidebar order by display name teams not present in the order preference * Fix iOS reload while developing * fix code causing tests to fail * feedback review * update network-client (cherry picked from commit ea2cb45) Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently signing in into a server that has many teams and threads can take a long time, this was mostly because of some
awaitcalls in the entry actions, specially around fetching the threads for teams.So in this PR we are refactoring the code a bit, first to defer some of the actions by pushing them to another event loop as well as changing some code to optimize certain things. Also in addition we introduced mattermost/mattermost#29042 so that we don't need to fetch the DM / GM threads for every team at start time as they are the same for every team and we can leave that sync to an on demand kind of scenario.
Note: This PR needs updating once mattermost/react-native-network-client#134 has been merged and released.
Ticket Link
Part of https://mattermost.atlassian.net/browse/MM-58384
Checklist
Environment
This PR was tested on a server with a user that belongs to 85 teams with hundreds of channels
Release Note