Match our Fork with go-ldap/ldap #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unified request flow && external binding to LDAP * fix debug mode * go.mod was added
* Rename asn1.ber dependency. * go mod tidy * Update travic CI to new asn1 ber * Update travis go_import_path
I believe that this (plus a new tag) is what is necessary for native go modules support -- right now go modules complains that the version tag is >= v2 but the module doesn't claim to be a version >= v2.
…go-ldap#247) * Moved v3 to subfolder to allow for versioning >2 with go modules. Reverted top level go.mod to fix backward compatibility * Updated readme to include directions on Go Modules, including the rationale
|
@hahmadia is this ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update our fork since https://mattermost.atlassian.net/browse/MM-19422 requires using a new version of a package ldap is using (asn1-ber) and without merging in the changes from go-ldap/ldap, it doesn't reference the correct module and updating will be difficult.