unified request flow && external binding to LDAP #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regeda
force-pushed
the
ldapi-external-bind
branch
from
9f7ed51
to
1485b0a
Compare
|
@johnweldon Could you review the PR? It's an essential update for an internal project I'm doing. |
|
This looks like a great PR from what I've reviewed so far - because it's more complex and large it'll take me a bit to do a full review. Thanks for the PR |
|
Hi @johnweldon |
johnweldon
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
LGTM - Thank you for contributing this
I like the internals refactoring, and the addition of the two Bind methods will be appreciated by others too.
I think this qualifies for a minor version bump (https://semver.org/#spec-item-7)
chinnareddy578
added a commit
to chinnareddy578/ldap
that referenced
this pull request
Oct 24, 2019
unified request flow && external binding to LDAP (go-ldap#232)
|
Thanks for merging. |
hahmadia
added a commit
to mattermost/ldap
that referenced
this pull request
Nov 25, 2019
* unified request flow && external binding to LDAP (go-ldap#232) * unified request flow && external binding to LDAP * fix debug mode * go.mod was added * Prevent negative waitgroup panic by `Add`ing first. (go-ldap#237) * Use github for module name. (go-ldap#239) * Rename asn1 ber dependency. (go-ldap#243) * Rename asn1.ber dependency. * go mod tidy * Update travic CI to new asn1 ber * Update travis go_import_path * Update README (go-ldap#245) * Update go.mod (go-ldap#241) I believe that this (plus a new tag) is what is necessary for native go modules support -- right now go modules complains that the version tag is >= v2 but the module doesn't claim to be a version >= v2. * Versioned v3 according to Go wiki, maintaining backward compatibility (go-ldap#247) * Moved v3 to subfolder to allow for versioning >2 with go modules. Reverted top level go.mod to fix backward compatibility * Updated readme to include directions on Go Modules, including the rationale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unified the request flow. Now, you could use
doRequestandreadPacketfunctions to work with requests.Also, I've added
SASL/EXTERNALmechanism for client authentication.