Verify SAML setup documentation for NameID #4296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for: #4267 Updated: - Self Managed Admin Guide > Onboard Users > SAML Single Sign-On (E20) > Configure SAML with Microsoft ADFS for Windows Server 2012 > Create Claim Rules - Updated step 3 to add another bullet point for creating a claim rule for `NameID`
Documentation for: #4267 Updated: - Self Managed Admin Guide > Onboard Users > SAML Single Sign-On (E20) > Configure SAML with Microsoft ADFS using Microsoft Windows Server 2016 > Create Claim Rules - Updated step 3 to add another bullet point for creating a claim rule for NameID - Other small formatting inconsistencies addressed
|
Newest code from cwarnermm has been published to preview environment |
Documentation for: #4267 Updated: - Fixed small style inconsistency
|
Newest code from cwarnermm has been published to preview environment |
cwarnermm
added
1: Dev Review
|
Newest code from cwarnermm has been published to preview environment |
Contributor
justinegeffen
left a comment
justinegeffen
left a comment
There was a problem hiding this comment.
I changed the formatting of the attribute names to match the formatting in the list - italics seemed out of place. The other option is to make the format bold to match UI formatting convention.
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
|
Newest code from cwarnermm has been published to preview environment |
sbishel
requested changes
Feb 9, 2021
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
sbishel
approved these changes
Feb 9, 2021
|
Newest code from cwarnermm has been published to preview environment |
1 similar comment
|
Newest code from cwarnermm has been published to preview environment |
justinegeffen
approved these changes
Feb 10, 2021
justinegeffen
removed
1: Dev Review
cwarnermm
added
3: Reviews Complete
amyblais
removed
the
3: Reviews Complete
justinegeffen
pushed a commit
that referenced
this pull request
Feb 18, 2021
* master: MM-31513 Document how team admins can see their teams' statistics (#4247) mmctl roles missing from product docs (#4275) Verify SAML setup documentation for NameID (#4296) MM-27688 - Implement OpenId Connect in Cloud (#4303) Update changelog.md (#4315) Update mobile-changelog.md (#4313) Fix typo in config-settings (#4312) MM-31518 Cloud Docs Technical Review Updates (#4227) MM-31575 ENV var license override (#4204) Update mmctl-cli-tool.rst (#4289) [MM-32393] Add documentation for the custom nginx template (#4295) MM-28549 Bump postgres version to 10 (#4221) Revert MM-27312 (#4305) Update version-archive.rst (#4310) Remove `ExperimentalDataPrefetch` from system console (#4132) V5.32 documentation (#4307) MM-30851 Replace ExperimentalChannelSidebarOrganization with EnableLegacySidebar (#4266) MM-31925 Channel Sidebar features no longer experimental (#4268) Cloud Changelog Feb 10th (#4280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for: #4267
Updated:
NameID