Skip to content

Conversation

@cwarnermm
Copy link
Member

Documentation for: https://mattermost.atlassian.net/browse/MM-31575

Updated:

  • Self-Managed Admin Guide > Configure Mattermost > Configuration Settings
    • Changed the following bolded lines to proper headings: "Configuration in Database", "Environment Variables", and "Load Custom Configuration Defaults"
    • Added new subsection "Override Mattermost License File"

Documentation for: https://mattermost.atlassian.net/browse/MM-31575

Updated:
- Self-Managed Admin Guide > Configure Mattermost > Configuration Settings
   - Changed the following bolded lines to proper headings: "Configuration in Database", "Environment Variables", and "Load Custom Configuration Defaults"
   - Added new subsection "Override Mattermost License File"
@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager 2: Editor Review Requires review by an editor labels Dec 31, 2020
@mattermod
Copy link
Contributor

Hello @cwarnermm,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@github-actions
Copy link

Published to preview environment cwarnermm

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 with one minor typo.

"In a high-availability environment, using an environment variable to override a server license only affect[s] the individual app server and doesn't propagate to other servers in the cluster."
@github-actions
Copy link

Published to preview environment cwarnermm

Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwarnermm cwarnermm removed 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager labels Jan 7, 2021
@amyblais amyblais added Awaiting Submitter Action Blocked on the author and removed 2: Editor Review Requires review by an editor labels Jan 29, 2021
@justinegeffen
Copy link
Contributor

@cwarnermm, just a reminder on this for my outstanding comments and your feedback. :)

cwarnermm and others added 2 commits February 5, 2021 10:04
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed Awaiting Submitter Action Blocked on the author labels Feb 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Published to preview environment cwarnermm

@justinegeffen justinegeffen merged commit 4cf3296 into master Feb 15, 2021
@justinegeffen justinegeffen deleted the MM-31575-ENV-var-license-override branch February 15, 2021 19:54
@github-actions
Copy link

Newest code from justinegeffen has been published to preview environment

@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Feb 16, 2021
justinegeffen pushed a commit that referenced this pull request Feb 18, 2021
* master:
  MM-31513 Document how team admins can see their teams' statistics (#4247)
  mmctl roles missing from product docs (#4275)
  Verify SAML setup documentation for NameID (#4296)
  MM-27688 - Implement OpenId Connect in Cloud (#4303)
  Update changelog.md (#4315)
  Update mobile-changelog.md (#4313)
  Fix typo in config-settings (#4312)
  MM-31518 Cloud Docs Technical Review Updates (#4227)
  MM-31575 ENV var license override (#4204)
  Update mmctl-cli-tool.rst (#4289)
  [MM-32393] Add documentation for the custom nginx template (#4295)
  MM-28549 Bump postgres version to 10 (#4221)
  Revert MM-27312 (#4305)
  Update version-archive.rst (#4310)
  Remove `ExperimentalDataPrefetch` from system console (#4132)
  V5.32 documentation (#4307)
  MM-30851 Replace ExperimentalChannelSidebarOrganization with EnableLegacySidebar (#4266)
  MM-31925 Channel Sidebar features no longer experimental (#4268)
  Cloud Changelog Feb 10th (#4280)
@cwarnermm cwarnermm added the 3: Reviews Complete All reviewers have approved the pull request label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants