[GH-33] Require events value are not emtpy upon a subscription save

[jfrerich]

Summary

This PR checks that a required dropdown event has at non-empty array and applies that check for the events dropdown.

Ticket Link

fixes #33

[DHaussermann]

@jfrerich This change does prevent the save. however, no validation message appears when events are left empty. This is a bit confusing because the UI just looks non-responsive.

Ideally this would show the text This field is required. the way the other ones do when the're missing.

[jfrerich]

@DHaussermann, can you double-check the message is not showing? When I click Save Subscription with empty events, I see the message appear.

[DHaussermann]

@jfrerich - This is strange. I am not seeing this text. I seem to get a JS error in the browser console.

• Redeployed this
• Tried refreshing and clearing cache
• Tested in browser and desktop
• Occurs on add and edit
  

[DHaussermann]

@jfrerich any thoughts on why we aren't seeing the same thing here? Should we connect or Zoom to see if we can sort it out?

[codecov-commenter]

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files           8        8           
  Lines         234      234           
=======================================
  Hits           69       69           
  Misses        153      153           
  Partials       12       12           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cc4cf...23de01a. Read the comment docs.

[jfrerich]

@DHaussermann. Thanks for catching edge case. For future reference, the select modal value is different when removing all events individually vs clearing all of them with the X in the RHS of the select box.

value = [] when clicking large X on RHS
value = null when remove each event individually.

This is ready for another review.

[DHaussermann]

Tested and passed

• Confirmed validation on events is working as expected
• Regression tested other other field validation
• Issue above has now been resolved
  Thanks @jfrerich for solving the edge case.
  LGTM!