Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A subscription can be saved with no events selected #33

Closed
DHaussermann opened this issue Apr 20, 2020 · 0 comments · Fixed by #65
Closed

A subscription can be saved with no events selected #33

DHaussermann opened this issue Apr 20, 2020 · 0 comments · Fixed by #65
Assignees
@jfrerich
Labels
Type/Enhancement New feature or improvement of existing feature
Milestone
v1.3.0

Comments

@DHaussermann
Copy link

When saving a subscription, it is possible to save when there are no events selected

We should validate against this to prevent the creation of subscriptions which deliver no events
@hanzei hanzei added Type/Bug Something isn't working Type/Enhancement New feature or improvement of existing feature and removed Type/Bug Something isn't working labels Apr 22, 2020
@jfrerich jfrerich added this to the v1.3.0 milestone Jul 15, 2020
@jfrerich jfrerich mentioned this issue Jul 15, 2020
Merged
@jfrerich jfrerich self-assigned this Jul 15, 2020
jfrerich added a commit that referenced this issue Aug 12, 2020
@jfrerich
[GH-33] Require events value are not emtpy upon a subscription save (#65
eed9fc7 
)

* check that events are not empty on save

* check for null value. This occurs when individually removing all the
events vs big x on RHS of select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfrerich jfrerich

Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
v1.3.0
3 participants
@jfrerich @hanzei @DHaussermann