Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped to v1.2.0 #52

Merged
merged 2 commits into from
May 27, 2020
Merged

Bumped to v1.2.0 #52

merged 2 commits into from
May 27, 2020

Conversation

levb
Copy link
Contributor

@levb levb commented May 12, 2020

Bumped release number.

First part of #51

@levb levb added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 12, 2020
@levb levb requested a review from jfrerich as a code owner May 12, 2020 23:23
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run make apply?

Edit: On my machine make apply is broken: #54

Maybe there is no need to run it.

@hanzei hanzei added this to the v1.2.0 milestone May 13, 2020
Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label May 13, 2020
@jfrerich
Copy link
Contributor

Perhaps they did not you the manifest files and that is something we should incorporate into the plugin to match it up with the other plugins.

@levb
Copy link
Contributor Author

levb commented May 13, 2020

@hanzei I ran make all - it usually updates everything. 0/5 that should be the standard operating procedure, not a specific make apply. Not sure if it needs the extra files, @mickmister @jfrerich can you comment?

@DHaussermann
Copy link

Not sure if this is helpful to the discussion above but - when I run make it seems to remove and re-add all NPM dependencies as if it does a make clean every time. I thought there may be some reason this was being done intentionally.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Ran through end to End testing
  • Tested on Confluence Cloud and Server
  • Tested upgrade and confined version bump successful
    LGTM! Will re-test if there any changes based on Dev review.

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels May 13, 2020
@hanzei hanzei added the Do Not Merge Should not be merged until this label is removed label May 14, 2020
@hanzei
Copy link
Collaborator

hanzei commented May 14, 2020

Blocking because #53 hasn't been merged

@DHaussermann
Copy link

End to end testing was already done on this. #52 (review) I was unaware that we were holding off for this PR #53

Once it's merged I can quickly double check the icon.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed labels May 22, 2020
@hanzei hanzei removed the request for review from mickmister May 22, 2020 18:48
@hanzei
Copy link
Collaborator

hanzei commented May 22, 2020

@levb I'm unsure if the CI correctly build and deploy github releases with the current setup in https://github.com/mattermost/mattermost-plugin-confluence/blob/master/.circleci/config.yml. Maybe it's more safe to sync with https://github.com/mattermost/mattermost-plugin-demo/blob/master/.circleci/config.yml first. Let me know if I can help.

@jfrerich
Copy link
Contributor

@hanzei, we discussed the issue of the circleCI and makefile differences. For the release and adding to marketplace, we don't have to have the circleCi fixes. I'll address the circleCi fixes in #54

@jfrerich jfrerich merged commit 7552296 into master May 27, 2020
@jfrerich jfrerich deleted the lev-bump-release branch May 27, 2020 16:21
@hanzei
Copy link
Collaborator

hanzei commented May 28, 2020

@jfrerich I've noticed that v1.2.0 is missing from https://github.com/mattermost/mattermost-plugin-confluence/releases. Do you need help with cutting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants