-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped to v1.2.0 #52
Bumped to v1.2.0 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run make apply
?
Edit: On my machine make apply
is broken: #54
Maybe there is no need to run it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perhaps they did not you the manifest files and that is something we should incorporate into the plugin to match it up with the other plugins. |
@hanzei I ran |
Not sure if this is helpful to the discussion above but - when I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Ran through end to End testing
- Tested on Confluence Cloud and Server
- Tested upgrade and confined version bump successful
LGTM! Will re-test if there any changes based on Dev review.
Blocking because #53 hasn't been merged |
End to end testing was already done on this. #52 (review) I was unaware that we were holding off for this PR #53 Once it's merged I can quickly double check the icon. |
@levb I'm unsure if the CI correctly build and deploy github releases with the current setup in https://github.com/mattermost/mattermost-plugin-confluence/blob/master/.circleci/config.yml. Maybe it's more safe to sync with https://github.com/mattermost/mattermost-plugin-demo/blob/master/.circleci/config.yml first. Let me know if I can help. |
@jfrerich I've noticed that |
Bumped release number.
First part of #51