Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make apply produces invalid files #54

Closed
hanzei opened this issue May 13, 2020 · 2 comments · Fixed by #68
Closed

make apply produces invalid files #54

hanzei opened this issue May 13, 2020 · 2 comments · Fixed by #68
Assignees
@jfrerich
Labels
Type/Bug Something isn't working
Milestone
v1.3.0

Comments

@hanzei
Copy link
Collaborator

hanzei commented May 13, 2020

make apply does output the files with escaped \n resulting in the output:
// This file is automatically generated. Do not modify it manually.\n\npackage config\n\nconst (\n\tPluginName = "com.mattermost.confluence"\n)

This should be fixed by synchronising the build tools with https://github.com/mattermost/mattermost-plugin-starter-template
@hanzei hanzei added the Type/Bug Something isn't working label May 13, 2020
@hanzei
Copy link
Collaborator Author

hanzei commented May 13, 2020

@jfrerich I'm wondering if you might take a look at this once you are done with the SET rotation

@jfrerich jfrerich self-assigned this May 13, 2020
@jfrerich
Copy link
Contributor

@hanzei, sure. I've self-assigned the issue.

@jfrerich jfrerich mentioned this issue May 27, 2020
Merged
@hanzei hanzei mentioned this issue Jun 9, 2020
Merged
@jfrerich jfrerich added this to the v1.3.0 milestone Jul 15, 2020
This was referenced Jul 27, 2020
Merged
Closed
@jfrerich jfrerich linked a pull request Jul 28, 2020 that will close this issue
[GH-54] sync with latest mattermost-plugin-starter-template #68
Merged
jfrerich added a commit that referenced this issue Aug 3, 2020
@jfrerich
Merge branch 'master' into GH-54-make-apply
08e778a
jfrerich added a commit that referenced this issue Aug 12, 2020
@jfrerich
Merge branch 'master' into GH-54-make-apply
a1a3145
jfrerich added a commit that referenced this issue Aug 21, 2020
@jfrerich
Merge branch 'master' into GH-54-make-apply
93d55b1
jfrerich added a commit that referenced this issue Sep 3, 2020
@jfrerich
[GH-54] sync with latest mattermost-plugin-starter-template (#68)
3cbffad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfrerich jfrerich

Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
v1.3.0
2 participants
@jfrerich @hanzei