Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2456 - Updating url property #2478

Merged
merged 1 commit into from
Mar 10, 2022
Merged

GH-2456 - Updating url property #2478

merged 1 commit into from
Mar 10, 2022

Conversation

asaadmahmood
Copy link
Contributor

Summary

GH-2456 - Updating url property

Ticket Link

Fixes #2456

@asaadmahmood asaadmahmood requested a review from a team as a code owner March 7, 2022 15:00
@asaadmahmood asaadmahmood requested review from jespino and harshilsharma63 and removed request for a team March 7, 2022 15:00
jespino
jespino reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 2: QA Review Requires review by a QA tester 3: Reviews Complete All reviewers have approved the pull request 2: Dev Review Requires review by a core committer and removed 3: Reviews Complete All reviewers have approved the pull request labels Mar 7, 2022
@asaadmahmood asaadmahmood added AutomatedCherryPick CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone AutomatedCherryPick labels Mar 8, 2022
@asaadmahmood asaadmahmood requested a review from jespino March 9, 2022 16:48
@jespino jespino merged commit b85f1ff into mattermost-community:main Mar 10, 2022
@jespino jespino added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 10, 2022
@asaadmahmood asaadmahmood deleted the GH-2456 branch July 28, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@harshilsharma63 harshilsharma63 Awaiting requested review from harshilsharma63 harshilsharma63 was automatically assigned from mattermost/core-focalboard

Assignees
No one assigned
Labels
2: QA Review Requires review by a QA tester 3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Long URL property expands card dialog width on hover
2 participants
@asaadmahmood @jespino