Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release artifact names and tags #866

Merged
merged 20 commits into from
Jan 24, 2025
Merged

fix: release artifact names and tags #866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b8b2a73
check release details
nbaztec Jan 24, 2025
c96f638
force run release
nbaztec Jan 24, 2025
52fa754
Merge branch 'main' into nish-release-tag
nbaztec Jan 24, 2025
0c2f5a9
don't force run release
nbaztec Jan 24, 2025
9a3f355
force run release with deafults
nbaztec Jan 24, 2025
0c6be1c
check nightly path
nbaztec Jan 24, 2025
a038a3e
fix nightly release name branch
nbaztec Jan 24, 2025
86a94d7
debug
nbaztec Jan 24, 2025
c01c212
fix test nightly condition
nbaztec Jan 24, 2025
8d6413c
generate correct version and tag names
nbaztec Jan 24, 2025
2202de2
fix script
nbaztec Jan 24, 2025
39c0162
add logs in step
nbaztec Jan 24, 2025
4c8125e
add logs in different step
nbaztec Jan 24, 2025
2e4c78d
verify nightly
nbaztec Jan 24, 2025
50243d3
fix version string if no tag
nbaztec Jan 24, 2025
6a05207
quote output
nbaztec Jan 24, 2025
66b0ce9
test with stable
nbaztec Jan 24, 2025
2bc86f0
cleanup
nbaztec Jan 24, 2025
1aa44f5
cleanup
nbaztec Jan 24, 2025
675abfb
cleanup
nbaztec Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix version string if no tag
  • Loading branch information
@nbaztec
nbaztec committed Jan 24, 2025
commit 50243d30f08ccda0563e6b0fcd5c9d5392a2c84a
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ jobs:
uses: ./.github/workflows/release.yml
with:
tag: ${{ needs.release-please.outputs.tag_name }}
version: "${{ needs.release-please.outputs.major }}.${{ needs.release-please.outputs.minor }}.${{ needs.release-please.outputs.patch }}"
version: ${{ (needs.release-please.outputs.tag_name && format('{0}.{1}.{2}', needs.release-please.outputs.major, needs.release-please.outputs.minor, needs.release-please.outputs.patch)) || ''}}
secrets: inherit
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,15 @@ jobs:
shell: bash
run: |
if [ "$PLATFORM_NAME" == "linux" ]; then
# tar -czvf "foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" -C ./target/${TARGET}/release forge cast
# echo "file_name=foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" >> $GITHUB_OUTPUT
echo "file_name=foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz"
# tar -czvf "foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" -C ./target/${TARGET}/release forge cast
# echo "file_name=foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" >> $GITHUB_OUTPUT
echo "file_name=foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz"
elif [ "$PLATFORM_NAME" == "darwin" ]; then
# We need to use gtar here otherwise the archive is corrupt.
# See: https://github.com/actions/virtual-environments/issues/2619
# gtar -czvf "foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" -C ./target/${TARGET}/release forge cast
# echo "file_name=foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" >> $GITHUB_OUTPUT
echo "file_name=foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz"
# gtar -czvf "foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" -C ./target/${TARGET}/release forge cast
# echo "file_name=foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" >> $GITHUB_OUTPUT
echo "file_name=foundry_zksync_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz"
fi

# - name: Build man page
Expand Down
Loading