Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release artifact names and tags #866

Merged
merged 20 commits into from
Jan 24, 2025
Merged

fix: release artifact names and tags #866

merged 20 commits into from
Jan 24, 2025

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Jan 24, 2025

What πŸ’»

  • Properly name artifacts when releasing.
  • Fix bug in IS_NIGHTLY detection.

Why βœ‹

  • We had inconsistency with nightly artifacts names with the stable ones.

Evidence πŸ“·

Action runs
https://github.com/matter-labs/foundry-zksync/actions/runs/12950423332/job/36123203197
https://github.com/matter-labs/foundry-zksync/actions/runs/12950402414/job/36123129539

Documentation πŸ“š

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

Notes πŸ“

We're currently using include-component-in-tag = true in release-please so our stable tags come out as foundry-zksync-v0.0.4 meanwhile nightly tags are nightly-{{sha}}, this is all good but if we don't need the component we should look into removing that part. @dutterbutter

@nbaztec nbaztec requested a review from a team as a code owner January 24, 2025 12:09
@dutterbutter
Copy link
Collaborator

We're currently using include-component-in-tag = true in release-please so our stable tags come out as foundry-zksync-v0.0.4 meanwhile nightly tags are nightly-{{sha}}, this is all good but if we don't need the component we should look into removing that part

@nbaztec we can look at removing, initially wanted to keep as I havent reviewed if folks rely on it in anyway. Upstream has it the same so we can review and look to remove if not needed.

@nbaztec nbaztec merged commit b993907 into main Jan 24, 2025
29 checks passed
@nbaztec nbaztec deleted the nish-release-tag branch January 24, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants