-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: release artifact names and tags #866
Conversation
@nbaztec we can look at removing, initially wanted to keep as I havent reviewed if folks rely on it in anyway. Upstream has it the same so we can review and look to remove if not needed. |
What π»
IS_NIGHTLY
detection.Why β
Evidence π·
Action runs
https://github.com/matter-labs/foundry-zksync/actions/runs/12950423332/job/36123203197
https://github.com/matter-labs/foundry-zksync/actions/runs/12950402414/job/36123129539
Documentation π
Please ensure the following before submitting your PR:
Notes π
We're currently using
include-component-in-tag = true
in release-please so our stable tags come out asfoundry-zksync-v0.0.4
meanwhile nightly tags arenightly-{{sha}}
, this is all good but if we don't need the component we should look into removing that part. @dutterbutter