fix(runtime): adding reject to args in loadEsmEntry (module-federatio…

…n#2067) Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com>
matt-pawley · Mar 5, 2024 · 4fc20cc · 4fc20cc
1 parent c15c3e7
commit 4fc20cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/late-wasps-watch.md b/.changeset/late-wasps-watch.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/runtime': patch
+---
+
+adding reject to args in loadEsmEntry
diff --git a/packages/runtime/src/utils/load.ts b/packages/runtime/src/utils/load.ts
@@ -20,9 +20,9 @@ export async function loadEsmEntry({
       if (!remoteEntryExports) {
         // eslint-disable-next-line no-eval
         new Function(
-          'resolve',
-          `import("${entry}").then((res)=>{resolve(res);}, (error)=> reject(error))`,
-        )(resolve);
+          'callbacks',
+          `import("${entry}").then(callbacks[0]).catch(callbacks[1])`,
+        )([resolve, reject]);
       } else {
         resolve(remoteEntryExports);
       }