Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): adding reject to args in loadEsmEntry #2067

Merged
merged 9 commits into from
Mar 5, 2024
Merged

fix(runtime): adding reject to args in loadEsmEntry #2067

merged 9 commits into from
Mar 5, 2024

Conversation

MadaraUchiha-314
Copy link
Contributor

@MadaraUchiha-314 MadaraUchiha-314 commented Feb 3, 2024 •
edited
Loading

Description

  • Small bug fix to include reject as a argument which was missing

If the reject args is not passed, we get the following error:

ReferenceError: reject is not defined

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@MadaraUchiha-314 MadaraUchiha-314 changed the title fix: adding reject to args fix(runtime): adding reject to args in loadEsmEntry Feb 3, 2024
@MadaraUchiha-314
Copy link
Contributor Author

@2heal1 @ScriptedAlchemy Can you help merge this PR ?

@ScriptedAlchemy
Copy link
Member

@MadaraUchiha-314 please run changesets add

@MadaraUchiha-314
Copy link
Contributor Author

@MadaraUchiha-314 please run changesets add

done

@ScriptedAlchemy
Copy link
Member

@MadaraUchiha-314 i updated this PR to use callbacks = [resolve,reject]

new Function can only take 2 args AFIK. so resolve reject need to be 1 var

@ScriptedAlchemy ScriptedAlchemy merged commit 4fc20cc into module-federation:main Mar 5, 2024
4 checks passed
@ScriptedAlchemy
Copy link
Member

@MadaraUchiha-314 try the next tag on npm - which should contain this released code

@zhoushaw zhoushaw mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScriptedAlchemy ScriptedAlchemy ScriptedAlchemy left review comments

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadaraUchiha-314 @ScriptedAlchemy