fix(runtime): adding reject to args in loadEsmEntry #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadaraUchiha-314
changed the title
Contributor
Author
|
@2heal1 @ScriptedAlchemy Can you help merge this PR ? |
Member
|
@MadaraUchiha-314 please run |
Contributor
Author
done |
Member
|
@MadaraUchiha-314 i updated this PR to use callbacks = [resolve,reject] new Function can only take 2 args AFIK. so resolve reject need to be 1 var |
Member
|
@MadaraUchiha-314 try the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
rejectargs is not passed, we get the following error:Related Issue
Types of changes
Checklist