Enable 3PID add/bind/unbind endpoints on r0 routes #7685
Conversation
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
the fact we've got this far without this breaking suggests that riot is relying on unstable working.
also: why did we not notice this when we checked if we were ready to advertise the version of the C-S API that adds these endpoints? Did we miss any others?
|
It seems we assumed (at least on web) that these would be r0 once the server supports r0.6.0 in versions. |
well that's good in a way, but also bad if it means that 1.15 has broken adding 3pids... |
With a quick test on matrix.org, it does indeed mean that: 3PID adding fails because we now try r0, since the server advertises r0.6.0. 😖 |
|
Darn, looks like we missed checking the right routes were advertised during #6585. |
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm other than bikeshedding over the changelog.
should probably target a 1.15.1 release though?
babolivier
force-pushed
the
babolivier/3pid_r0
branch
2 times, most recently
from
010c0d2 to
90821c1
Compare
babolivier
force-pushed
the
babolivier/3pid_r0
branch
from
90821c1 to
6d5985e
Compare
Looks like these endpoints made it to the r0 CS API but we never enabled them on the /r0 route.