This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cleanup top level request exception logging #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, we always logged that the request was being handled via `JsonResource._async_render`, so we change that to use the servlet name we add to the request. Secondly, we pass the exception information to the logger rather than formatting it manually. This makes it consistent with other exception logging, allwoing logging hooks and formatters to access the exception information.
Codecov Report
@@ Coverage Diff @@
## develop #4669 +/- ##
===========================================
- Coverage 75.27% 75.26% -0.01%
===========================================
Files 338 338
Lines 34626 34626
Branches 5670 5670
===========================================
- Hits 26064 26061 -3
- Misses 6966 6969 +3
Partials 1596 1596 |
richvdh
approved these changes
Feb 18, 2019
|
Me neither, but thought of refactoring all of this when its just there didn't appeal right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, we always logged that the request was being handled via
JsonResource._async_render, so we change that to use the servlet namewe add to the request.
Secondly, we pass the exception information to the logger rather than
formatting it manually. This makes it consistent with other exception
logging, allwoing logging hooks and formatters to access the exception
information.