Merge pull request #4669 from matrix-org/erikj/log_exception

Cleanup top level request exception logging
matrix-org · Feb 18, 2019 · 028267a · 028267a
2 parents d08bac4 + 12ae64c
commit 028267a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/4669.misc b/changelog.d/4669.misc
@@ -0,0 +1 @@
+Cleanup request exception logging
diff --git a/synapse/http/server.py b/synapse/http/server.py
@@ -106,10 +106,10 @@ def wrapped_request_handler(self, request):
             # trace.
             f = failure.Failure()
             logger.error(
-                "Failed handle request via %r: %r: %s",
-                h,
+                "Failed handle request via %r: %r",
+                request.request_metrics.name,
                 request,
-                f.getTraceback().rstrip(),
+                exc_info=(f.type, f.value, f.getTracebackObject()),
             )
             # Only respond with an error response if we haven't already started
             # writing, otherwise lets just kill the connection