This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Set thread_id column to non-null for event_push_{actions,actions_staging,summary} #15350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions_staging,actions,sumary} and set the column to non-nullable.
clokep
commented
Mar 29, 2023
Comment on lines
+16
to
+17
-- Force the background updates from 06thread_notifications.sql to run in the | ||
-- foreground as code will now require those to be "done". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikjohnston I doubt you remember, but does this sound like what we were looking to do in #14225 / #14222? I think it is, but would be curious if you have concerns!
reivilibre
suggested changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good otherwise
synapse/storage/schema/main/delta/74/03thread_notifications_not_null.sql.sqlite
Show resolved
Hide resolved
synapse/storage/schema/main/delta/74/03thread_notifications_not_null.sql.sqlite
Show resolved
Hide resolved
reivilibre
approved these changes
Mar 30, 2023
This was referenced Mar 31, 2023
clokep
added a commit
that referenced
this pull request
Apr 14, 2023
…ing,summary} (#15350) Clean-up from adding the thread_id column, which was initially null but backfilled with values. It is desirable to require it to now be non-null. In addition to altering this column to be non-null, we clean up obsolete background jobs, indexes, and just-in-time updating code.
clokep
added a commit
that referenced
this pull request
May 15, 2023
…ing,summary} (#15350) Clean-up from adding the thread_id column, which was initially null but backfilled with values. It is desirable to require it to now be non-null. In addition to altering this column to be non-null, we clean up obsolete background jobs, indexes, and just-in-time updating code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the schema to require a
thread_id
(i.e. make the column non-null) forevent_push_actions
,event_push_actions_staging
, andevent_push_actions_summary
.This bumps the schema compat version to 74. This was last bumped in #15036, which was released in v1.77.0rc2 so users will be unable to rollback to earlier than that version.
This has two commits which are mostly separate, it performs the following operations:
thread_id = null
in these tables.thread_id
column to be non-null.thread_id
column (and the background checker to see if the background update is done).Fixes #14225, reapplies part of #13776.