Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Set thread_id column to non-null for event_push_{actions,actions_staging,summary} #15437

Merged
merged 7 commits into from
May 3, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 14, 2023

Updates the schema to require a thread_id (i.e. add a constraint that the column is non-null) for event_push_actions, event_push_actions_staging, and event_push_actions_summary.

This bumps the schema compat version to 74. This was last bumped in #15036, which was released in v1.77.0rc2 so users will be unable to rollback to earlier than that version.

This has a few commits, it performs the following operations:

Fixes #14225
Fixes #15359

clokep and others added 4 commits April 14, 2023 10:47
…ing,summary} (#15350)

Clean-up from adding the thread_id column, which was initially
null but backfilled with values. It is desirable to require it to now
be non-null.

In addition to altering this column to be non-null, we clean up
obsolete background jobs, indexes, and just-in-time updating
code.
@clokep
Copy link
Member Author

clokep commented Apr 14, 2023

I'm not really sure how to test that this won't lock the table / cause matrix.org issues, but the documentation sounds like it should work?

@clokep
Copy link
Member Author

clokep commented Apr 14, 2023

Shout-out to @reivilibre for figuring out this approach, by the way!

@clokep clokep marked this pull request as ready for review April 14, 2023 16:06
@clokep clokep requested a review from a team as a code owner April 14, 2023 16:06
@clokep clokep requested a review from erikjohnston May 2, 2023 15:11
@clokep
Copy link
Member Author

clokep commented May 2, 2023

@erikjohnston I think this is all set now, pending CI being happy.

@clokep clokep merged commit a7b3e9c into develop May 3, 2023
@clokep clokep deleted the clokep/threads-clean-up branch May 3, 2023 11:49
erikjohnston added a commit that referenced this pull request May 12, 2023
erikjohnston added a commit that referenced this pull request May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-apply making thread_id required in push rules tables Make thread_id required in event_push tables
3 participants