This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Wait for room stream change cache position #14269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2022
Fizzadar
force-pushed
the
wait-for-stream-change-cache-position
branch
from
802fde1
to
93c781c
Compare
Fizzadar
changed the title
Fizzadar
force-pushed
the
wait-for-stream-change-cache-position
branch
from
44d74ff
to
dbebe7f
Compare
This appears to have previously been done within the room depth handling and only for local events.
Fizzadar
force-pushed
the
wait-for-stream-change-cache-position
branch
from
dbebe7f
to
9b5ef68
Compare
This was referenced Oct 23, 2022
| assert event.internal_metadata.stream_ordering is not None | ||
| self.store._events_stream_cache.entity_has_changed( | ||
| event.room_id, event.internal_metadata.stream_ordering | ||
| ) |
There was a problem hiding this comment.
Don't we do this at
called from
There was a problem hiding this comment.
Hm we do indeed. Could it be the async event cache changes? Specifically has this addition opened a gap here because the await call will mean the invalidation isn't handled synchronously? Nevermind the ID generator advances the token in a after_txn which always happens after the async callbacks so is safe.
I have reverted this change in 22d4ad1 leaving just the federated get_next call in update_current_state.
This is already handled as part of the invalidate caches for event callback.
|
Per discussion in #14158 this probably shouldn't be happening at all, but this change would at least log & address the issue pending any other fixes. |
|
Closing for now in favour of fixing the lefover races. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for race conditions between room stream change caches and invalidation over replication (see: #14158).
NOTE: this PR originally applied the wait for on device lists/device inbox stream change caches, but ran into a bunch of issues with those so leaving for a separate PR, this just focusses on rooms/events.
Signed off by Nick @ Beeper (@Fizzadar).
Pull Request Checklist
(run the linters)