This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Log stream cache behind current token #14239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should represent the position we know about and thus can safely query up to.
|
#14269 fixes one instance of this using the same technique, so closing this in favour of that and can look at the other occurrences of this afterwards. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically designed to track instances of #14158. Any time the warning is logged there is a risk of missed changes due to stream cache lagging behind the current token.
Signed off by Nick @ Beeper (@Fizzadar).
Pull Request Checklist
(run the linters)