This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Only build aarch64 wheels for cpython manylinux #14259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
added
the
X-Release-Blocker
DMRobertson
reviewed
Oct 21, 2022
pyproject.toml
Outdated
| [tool.cibuildwheel] | ||
| # Skip unsupported platforms (by us or by Rust). | ||
| skip = "cp36* *-musllinux_i686" | ||
| skip = "cp36* *-musllinux_i686 pp*aarch64 musllinux_aarch64" |
Contributor
There was a problem hiding this comment.
Should this be *-musllinux_aarch64?
DMRobertson
reviewed
Oct 21, 2022
Contributor
DMRobertson
left a comment
DMRobertson
left a comment
There was a problem hiding this comment.
I think this complements #14253 --- we should hopefully only build abi3 wheels for arm64 too?
Member
Author
I think that should happen automatically |
DMRobertson
approved these changes
Oct 21, 2022
This was
linked to
issues
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are too slow to build for everything else