Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Try building ABI3 wheels for cpython #14253

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Try building ABI3 wheels for cpython #14253

merged 3 commits into from
Oct 21, 2022

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston changed the base branch from develop to release-v1.70 October 21, 2022 13:12
@erikjohnston erikjohnston marked this pull request as ready for review October 21, 2022 13:14
@erikjohnston erikjohnston requested a review from a team as a code owner October 21, 2022 13:14
DMRobertson
DMRobertson suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these wheels still get tested by cibuildwheel?

Are we reducing the total number of wheels we build here---I don' think we are? If not, what's the motivation here?

.ci/scripts/auditwheel_wrapper.py Outdated Show resolved Hide resolved
.ci/scripts/auditwheel_wrapper.py Show resolved Hide resolved
@erikjohnston
Copy link
Member Author

Do these wheels still get tested by cibuildwheel?

Are we reducing the total number of wheels we build here---I don' think we are? If not, what's the motivation here?

Yup, cibuildwheel simply skips a build step if it finds an existing ABI compatible wheel. It'll still do the test step.

See https://github.com/matrix-org/synapse/actions/runs/3296929336 for a full run

@DMRobertson
Copy link
Contributor

Yup, cibuildwheel simply skips a build step if it finds an existing ABI compatible wheel.

Brilliant, thanks for confirming!

DMRobertson
DMRobertson approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for pedantry. LGTM!

@DMRobertson
Copy link
Contributor

(though I'm personally still tempted to ditch i686 wheels)

@erikjohnston erikjohnston enabled auto-merge (squash) October 21, 2022 13:39
@erikjohnston erikjohnston mentioned this pull request Oct 21, 2022
Merged
@erikjohnston erikjohnston merged commit 5f77b74 into release-v1.70 Oct 21, 2022
@erikjohnston erikjohnston deleted the erikj/abi3_wheels branch October 21, 2022 14:17
DMRobertson pushed a commit that referenced this pull request Oct 24, 2022
Fix typo in cibuildwheel conf introduced in #14253
1e73eff
@clokep
Copy link
Member

clokep commented Oct 24, 2022

Follow-up typo fix: 1e73eff

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikjohnston @DMRobertson @clokep