This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove unnecessary use of jquery on the recaptcha page. #11406
Prev
Previous commit
Removed unnecessary jquery and modified changelog.d
- Loading branch information
commit e4d3d882a22e8e49288fd4a02c5931d169cd5ab8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Removes unnecessary use of jquery on the recaptcha page from `synapse/synapse/res/templates/recaptcha.html`. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will mean much to the average synapse admin. It would be better to say where this page is used.
I believe it's the fallback page for clients which don't support recaptcha themselves? Have you been able to test it, at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richvdh I ran the local server but I'm unable to test it, I'm unable to find the correct path of the page.
This is the url
http://localhost:8080/_matrix/static/what should be the path to append if I want to test this feature? :' )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://localhost:8008/_matrix/client/v3/auth/m.login.recaptcha/fallback/web?session=abc is the location of the recaptcha fallback page, which should load the contents of the configured
recaptcha.htmltemplate.This was a discussion on how to test this manually locally in #synapse-dev here: https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$xWMp0Ah_BKfWz9IxE7uUP2Tpzanem6hdDJjRaxsXGNI?via=matrix.org&via=vector.modular.im&via=envs.net